From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 1/3] scsi_tgt_lib: Use scsi_init_io instead of scsi_alloc_sgtable Date: Thu, 08 Nov 2007 16:01:53 +0200 Message-ID: <473316D1.2020603@panasas.com> References: <4730AF73.7010009@panasas.com> <20071108121321F.fujita.tomonori@lab.ntt.co.jp> <4732C9B8.6050204@panasas.com> <20071108220325R.tomof@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from sa2.bezeqint.net ([192.115.104.16]:57879 "EHLO sa2.bezeqint.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757691AbXKHOCE (ORCPT ); Thu, 8 Nov 2007 09:02:04 -0500 In-Reply-To: <20071108220325R.tomof@acm.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: FUJITA Tomonori , James.Bottomley@SteelEye.com Cc: bhalevy@panasas.com, fujita.tomonori@lab.ntt.co.jp, michaelc@cs.wisc.edu, linux-scsi@vger.kernel.org, pw@osc.edu On Thu, Nov 08 2007 at 15:04 +0200, FUJITA Tomonori wrote: > On Thu, 08 Nov 2007 10:32:56 +0200 > Benny Halevy wrote: > >> On Nov. 08, 2007, 5:13 +0200, FUJITA Tomonori wrote: >>> On Tue, 06 Nov 2007 20:16:19 +0200 >>> Boaz Harrosh wrote: >>> >>>> - If we export scsi_init_io()/scsi_release_buffers() instead of >>>> scsi_{alloc,free}_sgtable() from scsi_lib than tgt code is >>>> much more insulated from scsi_lib changes. As a bonus it will >>>> also gain bidi capability when it comes. >>>> >>>> Signed-off-by: Boaz Harrosh >>> Looks good for me except for this: >>> >>> ./scripts/checkpatch.pl ~/Mail/kernel/scsi/28814 >>> ERROR: use tabs not spaces >>> #101: FILE: drivers/scsi/scsi_lib.c:741: >>> + gfp_t gfp_mask)$ >> Come on Tomo, tabs should be used for nesting, not for decoration. >> This way no matter what's your tab expansion setup is the >> code will look correct and will make sense. The number of space > > I've never heard about that rule. I use tabs and minimum spaces for > decoration. > > But it's just about the style. The patch is fine by me if you like to > use only spaces there. > > Thanks, Thanks Tomo, I'm resending with the way you like it. You are the maintainer and you should be comfortable with the code. I do need your Signed-off-by on this. Since you are the maintainer. Do you want that we push this through James, or through your tree? Thanks again, will send revision soon. Boaz