All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	bhalevy@panasas.com, linux-crypto@vger.kernel.org,
	michaelc@cs.wisc.edu, netdev@vger.kernel.org
Subject: Re: Fwd: Re: [PATCH] iSCSI fix endieness of digest to be network byte order
Date: Thu, 08 Nov 2007 10:47:44 -0500	[thread overview]
Message-ID: <47332FA0.2020405@hp.com> (raw)
In-Reply-To: <20071108104040.GA16312@gondor.apana.org.au>

Herbert Xu wrote:
> On Thu, Nov 08, 2007 at 05:04:09PM +0900, FUJITA Tomonori wrote:
>> I wonder why crc32c isn't used directly while crc32 is used directly
>> since they vary by only the polynomial.
> 
> It's because iSCSI uses it with scatterlists.  The crypto layer
> provides a nice interface for that while using it directly would
> require the user to do the scatterlist walk.
> 
>> Using crc32c directly might enable us to kill net/sctp/crc32c.c and
>> merge lib/crc32.c and lib/libcrc32c?
> 
> I'm pretty sure we can kill net/sctp/crc32c.c today by converting
> it over to use the crypto interface.


Funny, I looked for crc32c in the lib just the other week and didn't spot
it.  Need to look harder :)

-vlad

      reply	other threads:[~2007-11-08 15:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 19:04 Fwd: Re: [PATCH] iSCSI fix endieness of digest to be network byte order Benny Halevy
2007-11-08  1:18 ` Herbert Xu
2007-11-08  8:04   ` FUJITA Tomonori
2007-11-08 10:40     ` Herbert Xu
2007-11-08 15:47       ` Vlad Yasevich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47332FA0.2020405@hp.com \
    --to=vladislav.yasevich@hp.com \
    --cc=bhalevy@panasas.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.