All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <aystarik@gmail.com>
To: "Li, Shaohua" <shaohua.li@intel.com>
Cc: "Moore, Robert" <robert.moore@intel.com>,
	"Lin, Ming M" <ming.m.lin@intel.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: GPE handling
Date: Fri, 09 Nov 2007 12:45:10 +0300	[thread overview]
Message-ID: <47342C26.2040505@gmail.com> (raw)
In-Reply-To: <FC1D1B23302A22499C60C967336B2AE001FF2CA9@pdsmsx411.ccr.corp.intel.com>

Shaohua,
There is cond_resched() before the exit from deferred execution routine,
specifically to let notify thread a chance to execute.
Thus by the time deferred execution is exited, notify should be already 
done,
and we could safely enable _Lxx again.
Do you think it is not sufficient?

Regards,
Alex.

Li, Shaohua wrote:
> Bob & Ming,
> I'm working on adding wakeup GPE support at system runtime, this
> capability can help us
> Identify which device invokes a wakeup event at runtime, this is
> required for runtime device
> Power management.
>
> Below is the ASL code. For example, _L0c, USB3 will send a wakeup GPE
> and invoke
> a notify. In the notify handler, OS will clear USB3's PCI PME status to
> avoid wakeup
> event flood. But in current code, acpi_ev_asynch_execute_gpe_method will
> start an asynchronous
> execution of notify and return soon. Just before the return,
> acpi_ev_asynch_execute_gpe_method
> will reenable GPE 0C. That means GPE is enabled before OS execute
> notification handler and USB3's
> PCI PME status is cleared, and cause GPE flood. Ideally, I think we
> should delay GPE enable
> of _L0c till notification handler is finished or simply the method _L0c
> is really finished.
> What do you think?
>
> Thanks,
> Shaohua
>
>
>         Method (_L0C, 0, NotSerialized)
>         {
>             Notify (\_SB.PCI0.USB3, 0x02)
>         }
>
>         Method (_L0D, 0, NotSerialized)
>         {
>             Notify (\_SB.PCI0.USB7, 0x02)
>         }
>
>         Method (_L0E, 0, NotSerialized)
>         {
>             Notify (\_SB.PCI0.USB4, 0x02)
>         }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   


  reply	other threads:[~2007-11-09  9:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-09  7:50 GPE handling Li, Shaohua
2007-11-09  9:45 ` Alexey Starikovskiy [this message]
2007-11-12  0:42   ` Shaohua Li
2007-11-13 10:05     ` [PATCH] ACPI: Defer enabling of level GPE until all pending notifies done Alexey Starikovskiy
2007-11-15  5:44       ` [PATCH] ACPI: Defer enabling of level GPE until all pending notifiesdone Shaohua Li
2007-12-07  2:55       ` [PATCH] ACPI: Defer enabling of level GPE until all pending notifies done Len Brown
2008-02-02  9:45       ` Len Brown
2008-02-02 11:03         ` Alexey Starikovskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47342C26.2040505@gmail.com \
    --to=aystarik@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=robert.moore@intel.com \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.