From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 15/15] ide: remove 'tf_in_flags' field from ide_task_t
Date: Fri, 09 Nov 2007 16:59:36 +0300 [thread overview]
Message-ID: <473467C8.9080103@ru.mvista.com> (raw)
In-Reply-To: <200710310055.22468.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * Add IDE_TFLAG_IN_DATA taskfile flag to indicate the need of reading
> IDE_DATA_REG in ide_end_drive_cmd().
> Set the new flag in ide_taskfile_ioctl() if ->in_flags.b.data is set.
> * Add IDE_TFLAG_FLAGGED_SET_IN_FLAGS taskfile flag to indicate the
> need of modifying ->in_flags in ide_taskfile_ioctl().
> Set the new flag in flagged_taskfile() and move the code modifying
> ->tf_in_flags to ide_taskfile_ioctl().
> While at it remove the bogus comment: ->tf_in_flags (except .b.data)
> have no effect on selection of registers to read.
> * Remove no longer needed 'tf_in_flags' field from ide_task_t.
> As the result we finally have the internals of HDIO_DRIVE_TASKFILE ioctl
> separated from the core IDE code.
> There should be no functionality changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-11-09 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 23:55 [PATCH 15/15] ide: remove 'tf_in_flags' field from ide_task_t Bartlomiej Zolnierkiewicz
2007-11-09 13:59 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473467C8.9080103@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.