From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Remove uninitialized cow if snapshot creation fails
Date: Fri, 09 Nov 2007 11:40:52 -0500 [thread overview]
Message-ID: <47348D94.3090603@ce.jp.nec.com> (raw)
Similar to the mirror log cleanup, snapshot cow also should be
removed if the snapshot creation fails.
# dmsetup create --notable testvg-lvol1-cow
# lvcreate -s -l1 -n lvol1 testvg/lvol0
/dev/testvg/lvol1: not found: device not cleared
Aborting. Failed to wipe snapshot exception store. Remove new LV and retry.
# lvs
LV VG Attr LSize Origin Snap% Move Log Copy%
lvol0 testvg -wi-a- 4.00M
lvol1 testvg -wi--- 4.00M
Attached patch removes the incomplete COW LV if the snapshot
creation fails.
A test script is also attached.
Thanks,
--
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvm2-cleanup-cow-on-init-failure.patch
Type: text/x-patch
Size: 2476 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20071109/a2fa5ee8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup-lvcreate-snapshot.sh
Type: application/x-sh
Size: 1477 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20071109/a2fa5ee8/attachment.sh>
reply other threads:[~2007-11-09 16:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47348D94.3090603@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.