All of lore.kernel.org
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	Paul Mackerras <paulus@samba.org>,
	Git Mailing List <git@vger.kernel.org>,
	Pierre Habouzit <madcoder@debian.org>
Subject: Re: [PATCH 2/2] --pretty=format: on-demand format expansion
Date: Fri, 09 Nov 2007 22:13:28 +0100	[thread overview]
Message-ID: <4734CD78.4000704@lsrfire.ath.cx> (raw)
In-Reply-To: <Pine.LNX.4.64.0711090122470.4362@racer.site>

Johannes Schindelin schrieb:
> Hi,
> 
> On Fri, 9 Nov 2007, Ren? Scharfe wrote:
> 
>>  strbuf.c |   24 ++++++
>>  strbuf.h |    3 +
>>  pretty.c |  276 ++++++++++++++++++++++++++++++++++----------------------------
> 
> I would be so grateful if you could (trivially) split up this patch into 
> the addition of strbuf_expend() (with a small example in the commit 
> message), and a patch that uses it in pretty.c.

Makes sense.  Will do next time.

Thanks,
René

  reply	other threads:[~2007-11-09 21:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-09  0:49 [PATCH 2/2] --pretty=format: on-demand format expansion René Scharfe
2007-11-09  1:24 ` Johannes Schindelin
2007-11-09 21:13   ` René Scharfe [this message]
2007-11-09 22:18     ` Johannes Schindelin
2007-11-09 22:30       ` Junio C Hamano
2007-11-09  4:50 ` Jeff King
2007-11-09 23:16   ` René Scharfe
2007-11-10  0:31     ` Johannes Schindelin
2007-11-10  0:49       ` Jeff King
2007-11-10  0:46     ` Jeff King
2007-11-10 11:12       ` René Scharfe
2007-11-10 16:07         ` Johannes Schindelin
2007-11-10 16:24           ` René Scharfe
2007-11-10 20:36           ` Jeff King
2007-11-10 20:34         ` Jeff King
2007-11-11  8:13           ` Jeff King
2007-11-10 11:14       ` [PATCH 1/3] --pretty=format: parse commit message only once René Scharfe
2007-11-10 11:16       ` [PATCH 2/3] add strbuf_adddup() René Scharfe
2007-11-10 11:18       ` [PATCH 3/3] --format=pretty: avoid calculating expensive expansions twice René Scharfe
2007-11-11 10:29         ` Junio C Hamano
2007-11-09  4:52 ` [PATCH 2/2] --pretty=format: on-demand format expansion Jeff King
2007-11-09 23:20   ` René Scharfe
2007-11-10  0:51     ` Jeff King
2007-11-09 23:39 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4734CD78.4000704@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=madcoder@debian.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.