All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Franke <Christian.Franke@t-online.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] grub-probe -t prefix, -t all
Date: Sat, 10 Nov 2007 01:03:25 +0100	[thread overview]
Message-ID: <4734F54D.1090305@t-online.de> (raw)
In-Reply-To: <20071109225640.GB939@thorin>

Robert Millan wrote:
> ...
> Note that make_system_path_relative_to_its_root() actually exists :-/
>
>   

Sorry, I didn't search update-grub_lib.in :-\

Apparently both grub_get_prefix() and 
make_system_path_relative_to_its_root() use the same algorithm. Both do 
not work on Cygwin due to special (multi- to single-root) mount point 
handling.

It is desirable to have only one implementation for this non-trivial 
function. A native C implementation is needed for grub-setup, therefore 
"grub-probe -t prefix" makes sense for scripts.


> If you provide an (obviously better) way to do the same thing, maybe you
> could also get rid of the other one in your patch?
>
>   

Yes.

Christian




      reply	other threads:[~2007-11-10  0:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29 20:20 [PATCH] grub-probe -t prefix, -t all Christian Franke
2007-11-09 21:13 ` Robert Millan
2007-11-09 21:42   ` Christian Franke
2007-11-09 22:56     ` Robert Millan
2007-11-10  0:03       ` Christian Franke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4734F54D.1090305@t-online.de \
    --to=christian.franke@t-online.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.