Re: [PATCH] Add host open devicename check

[Christian Franke <Christian.Franke@t-online.de>]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

Marco Gerards wrote:
>> ..
>>
>> 2007-10-25  Christian Franke  <franke@computer.org>
>>
>> 	* disk/host.c (grub_host_open): Add check for "host". This fixes
>> 	the problem that grub-emu does not find partitions.
>>     
>
> Please mention the attribute change.
>
>   
>> ...
>>  static grub_err_t
>> -grub_host_open (const char *name __attribute((unused)), grub_disk_t disk)
>> +grub_host_open (const char *name, grub_disk_t disk)
>>  {
>> +  if (grub_strcmp(name, "host"))
>> +      return grub_error (GRUB_ERR_UNKNOWN_DEVICE, "not a host disk");
>>     
>
> Please add a space after the function name and before the "(".
>
>   

Done

Christian

2007-11-10  Christian Franke  <franke@computer.org>

	* disk/host.c (grub_host_open): Remove attribute unused from
	name parameter. Add check for "host". This fixes the problem
	that grub-emu does not find partitions.



[-- Attachment #2: grub2-host_open-2.patch --]
[-- Type: text/x-patch, Size: 504 bytes --]

--- grub2.orig/disk/host.c	2007-08-02 19:24:05.000000000 +0200
+++ grub2/disk/host.c	2007-11-10 14:18:11.046875000 +0100
@@ -34,8 +34,11 @@ grub_host_iterate (int (*hook) (const ch
 }
 
 static grub_err_t
-grub_host_open (const char *name __attribute((unused)), grub_disk_t disk)
+grub_host_open (const char *name, grub_disk_t disk)
 {
+  if (grub_strcmp (name, "host"))
+      return grub_error (GRUB_ERR_UNKNOWN_DEVICE, "not a host disk");
+
   disk->total_sectors = 0;
   disk->id = (int) "host";