From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1Iqut3-00074j-Vo
	for mharc-grub-devel@gnu.org; Sat, 10 Nov 2007 13:16:54 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Iqut2-00072p-Ez
	for grub-devel@gnu.org; Sat, 10 Nov 2007 13:16:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Iqut1-00071s-0Y
	for grub-devel@gnu.org; Sat, 10 Nov 2007 13:16:52 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Iqut0-00071h-Ey
	for grub-devel@gnu.org; Sat, 10 Nov 2007 13:16:50 -0500
Received: from mailout09.sul.t-online.de ([194.25.134.84]
	helo=mailout09.sul.t-online.com)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Christian.Franke@t-online.de>) id 1Iqut0-0001CD-6o
	for grub-devel@gnu.org; Sat, 10 Nov 2007 13:16:50 -0500
Received: from fwd28.aul.t-online.de by mailout09.sul.t-online.com with smtp 
	id 1Iqusz-00072x-02; Sat, 10 Nov 2007 19:16:49 +0100
Received: from [10.3.2.2]
	(VmsVwEZXZh2rmoKOygTR0cYu-HRytg9o+4DyPlZRBUJQpm9jDhw9cct6v4kRpLdZJt@[217.235.225.69])
	by fwd28.aul.t-online.de
	with esmtp id 1Iqust-1N1xeS0; Sat, 10 Nov 2007 19:16:43 +0100
Message-ID: <4735F588.5020401@t-online.de>
Date: Sat, 10 Nov 2007 19:16:40 +0100
From: Christian Franke <Christian.Franke@t-online.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
	rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <471E5075.9090309@t-online.de>
	<472B8FA5.5030400@t-online.de>	<874pfvmpta.fsf@xs4all.nl>
	<4734CBEB.7080500@t-online.de> <87ve8agk9n.fsf@xs4all.nl>
In-Reply-To: <87ve8agk9n.fsf@xs4all.nl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-ID: VmsVwEZXZh2rmoKOygTR0cYu-HRytg9o+4DyPlZRBUJQpm9jDhw9cct6v4kRpLdZJt
X-TOI-MSGID: 39db24ff-0a4f-4494-8361-c1bdfb649b6f
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3)
Subject: Re: [PATCH] Allow build without dirent.d_type, fix "ls (host)" crash
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Nov 2007 18:16:52 -0000

Marco Gerards wrote:
>> ...
>> 2007-11-09  Christian Franke  <franke@computer.org>
>>
>> 	* util/hostfs.c (is_dir): New function.
>> 	(grub_hostfs_dir):  Handle missing dirent.d_type case.
>> 	(grub_hostfs_read): Add missing fseek().
>> 	(grub_hostfs_label): Clear label pointer.  This fixes a crash
>> 	of grub-emu on "ls (host)".
>>     
>
> Looks fine to me.
>   

Thanks.

> btw, when do you use (host)?  It's intended as a debugging tool.
>   

It was there, it didn't work, and it breaked remaining grub-emu device 
access at all. So I fixed it :-)

Christian