From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/pseries: Mark accumulate_stolen_time() as notrace
Date: Wed, 30 Oct 2019 23:14:23 +1100 (AEDT) [thread overview]
Message-ID: <4736nr03ZLz9sRM@ozlabs.org> (raw)
In-Reply-To: <20191024055932.27940-1-mpe@ellerman.id.au>
On Thu, 2019-10-24 at 05:59:32 UTC, Michael Ellerman wrote:
> accumulate_stolen_time() is called prior to interrupt state being
> reconciled, which can trip the warning in arch_local_irq_restore():
>
> WARNING: CPU: 5 PID: 1017 at arch/powerpc/kernel/irq.c:258 .arch_local_irq_restore+0x9c/0x130
> ...
> NIP .arch_local_irq_restore+0x9c/0x130
> LR .rb_start_commit+0x38/0x80
> Call Trace:
> .ring_buffer_lock_reserve+0xe4/0x620
> .trace_function+0x44/0x210
> .function_trace_call+0x148/0x170
> .ftrace_ops_no_ops+0x180/0x1d0
> ftrace_call+0x4/0x8
> .accumulate_stolen_time+0x1c/0xb0
> decrementer_common+0x124/0x160
>
> For now just mark it as notrace. We may change the ordering to call it
> after interrupt state has been reconciled, but that is a larger
> change.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/eb8e20f89093b64f48975c74ccb114e6775cee22
cheers
prev parent reply other threads:[~2019-10-30 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 5:59 [PATCH] powerpc/pseries: Mark accumulate_stolen_time() as notrace Michael Ellerman
2019-10-30 12:14 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4736nr03ZLz9sRM@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.