All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: "Templin, Fred L" <Fred.L.Templin@boeing.com>
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)
Date: Mon, 12 Nov 2007 17:22:48 -0500	[thread overview]
Message-ID: <4738D238.8050105@hp.com> (raw)
In-Reply-To: <39C363776A4E8C4A94691D2BD9D1C9A1029EDC21@XCH-NW-7V2.nw.nos.boeing.com>

Hi Fred

Templin, Fred L wrote:
> Vlad,
> 
> Yes, I was breaking into multiples to ease review only.
> The "[PATCH 01/04] ... (5)" thread includes the complete
> reviewable and patchable final text in 4 files. In my
> next message, I will put the entire patchfile as inline
> text. (The "[PATCH 01/01] ... (5)" for 'iproute2' is
> already complete.)
> 

Ok, thanks for the explanation.  One questions is though why
do we need all the #if defines() throughout the file?

Most distros end up enabled almost everything anyway.  Looking
at the code, there is really nothing that needs a conditional.
Removing the conditionals would make things cleaner.

Just some of my thoughts.

Thanks
-vlad

  reply	other threads:[~2007-11-12 22:22 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12 21:01 [Resend][PATCH 01/05] ipv6: RFC4214 Support (4) Templin, Fred L
2007-11-12 22:03 ` [PATCH 01/04] ipv6: RFC4214 Support (5) Templin, Fred L
2007-11-12 22:03 ` [PATCH 02/04] " Templin, Fred L
2007-11-12 22:03 ` [PATCH 03/05] " Templin, Fred L
2007-11-12 22:03 ` [PATCH 04/04] " Templin, Fred L
2007-11-12 22:18   ` [PATCH 05/05] " Templin, Fred L
2007-11-12 23:14     ` [PATCH 01/01] ipv6: RFC4214 Support (v2.0) Templin, Fred L
2007-11-13 15:51       ` Vlad Yasevich
2007-11-13 16:32         ` Templin, Fred L
2007-11-13 16:59           ` Vlad Yasevich
2007-11-13 17:29             ` Templin, Fred L
2007-11-13 18:01             ` [PATCH 01/01] ipv6: RFC4214 Support (v2.1) Templin, Fred L
2007-11-13 19:03               ` Vlad Yasevich
2007-11-15  6:44               ` [PATCH 01/01] ipv6: RFC4214 Support (v2.2) Templin, Fred L
2007-11-15 11:22                 ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-15 18:06                   ` Templin, Fred L
2007-11-15 11:48                 ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-15 18:11                   ` Templin, Fred L
2007-11-15 18:44                     ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-15 21:59                       ` Templin, Fred L
2007-11-20 17:36                 ` [PATCH 01/01] ipv6: RFC4214 Support (v2.4) Templin, Fred L
2007-11-20 17:43                   ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-21  1:34                   ` David Miller
2007-11-21  1:41                     ` David Miller
2007-11-26 17:16                   ` [PATCH 01/01] ipv6: RFC4214 Support (v2.5) Templin, Fred L
2007-11-26 18:00                     ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-27 16:57                       ` Templin, Fred L
2007-11-29 10:29                     ` Herbert Xu
2007-11-29 10:54                       ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-29 11:12                         ` Herbert Xu
2008-01-15 19:57                         ` [PATCH 01/03] ISATAP V2 (header file changes) Templin, Fred L
2008-01-15 19:59                           ` [PATCH 02/03] ISATAP V2 (ndisc.c; route.c changes) Templin, Fred L
2008-01-15 20:00                           ` [PATCH 03/03] ISATAP V2 (sit.c changes) Templin, Fred L
2008-01-22 16:51                           ` status inquiry (RE: [PATCH 01/03] ISATAP V2 (header file changes)) Templin, Fred L
2008-01-29 16:41                           ` status inquiry#2 " Templin, Fred L
2008-02-05 17:53                           ` status inquiry #3 " Templin, Fred L
2008-03-24  5:37                           ` [PATCH 01/03] ISATAP V2 (header file changes) YOSHIFUJI Hideaki / 吉藤英明
2007-11-12 22:11 ` [Resend][PATCH 01/05] ipv6: RFC4214 Support (4) Vlad Yasevich
2007-11-12 22:15   ` Templin, Fred L
2007-11-12 22:22     ` Vlad Yasevich [this message]
2007-11-12 22:26       ` Templin, Fred L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4738D238.8050105@hp.com \
    --to=vladislav.yasevich@hp.com \
    --cc=Fred.L.Templin@boeing.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.