From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/13] ide: (hopefully) fix VDMA for CS5520
Date: Tue, 13 Nov 2007 14:17:44 +0300 [thread overview]
Message-ID: <473987D8.6030409@ru.mvista.com> (raw)
In-Reply-To: <200711130001.28320.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * Set the correct hwif->dma_base for the second channel in
> ide_get_or_set_dma_base().
> * Remove DMA enable code from cs5520_set_pio_mode(), this can
> be handled by the generic ->dma_host_on method now.
> * Add VDMA check to ide_config_drive_speed().
> * drive->using_dma was never enabled since cs5520 host driver's
> ->ide_dma_on method overrided the generic ->ide_dma_on (so
> __ide_dma_on() was never called, drive->using_dma was never set
> and VDMA was never used since it depends on drive->using_dma).
> Fix it by using ->dma_host_on method instead of ->ide_dma_on
> (also add matching ->dma_host_off method).
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-11-13 11:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 23:01 [PATCH 3/13] ide: (hopefully) fix VDMA for CS5520 Bartlomiej Zolnierkiewicz
2007-11-13 11:17 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473987D8.6030409@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.