All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Rainer Jochem <rainer.jochem@mpi-sb.mpg.de>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	pcernko@mpi-sws.mpg.de
Subject: Re: [PATCH] ipconfig.c : implement DHCP Class-identifier
Date: Wed, 14 Nov 2007 10:48:43 +0100	[thread overview]
Message-ID: <473AC47B.9070509@trash.net> (raw)
In-Reply-To: <20071114094508.GA6004@mpi-sb.mpg.de>

Rainer Jochem wrote:
> 
>> I don't think its very useful since you can simply get this information
>> from /proc/cmdline in case something goes wrong, but if you insist at
>> least give it a meaningful prefix.
> 
> Added.
> 
>> The initialization is unnecessary.
> 
> Removed.
> 
>> Should be >= I think.
> 
> Fixed.


Looks fine, thanks.



  reply	other threads:[~2007-11-14  9:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-08 14:32 [PATCH] ipconfig.c : implement DHCP Class-identifier Rainer Jochem
2007-11-08 15:45 ` Patrick McHardy
2007-11-14  8:44   ` Rainer Jochem
2007-11-14  8:56     ` Patrick McHardy
2007-11-14  9:45       ` Rainer Jochem
2007-11-14  9:48         ` Patrick McHardy [this message]
2007-11-14 10:18           ` David Miller
2007-11-14 22:11         ` Francois Romieu
2007-11-20  5:56           ` David Miller
2007-11-08 20:27 ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473AC47B.9070509@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pcernko@mpi-sws.mpg.de \
    --cc=rainer.jochem@mpi-sb.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.