From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Thiemo Seufer <ths@networkno.de>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] Introduce __fill_user() and kill __bzero()
Date: Wed, 14 Nov 2007 13:34:26 +0100 [thread overview]
Message-ID: <473AEB52.40501@gmail.com> (raw)
In-Reply-To: <20071114115807.GL8363@networkno.de>
Thiemo Seufer wrote:
> In general we do (think of stack unwinding etc.). I believe this
> implementation should move to C, as it doesn't need an assembler
> implementation:
>
> void *memset (void *s, int c, kernel_size_t n)
> {
> __fill_user(s, c, n);
> return s;
> }
>
> It looks much nicer that way. :-)
>
Sure but memset.S was a really good place to implement memset(), wasn't
it ?
And since the implementation should have been trivial, I thought it was
ok to implement in assembly.
Ok, I'll look for another place.
Thanks,
Franck
next prev parent reply other threads:[~2007-11-14 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-11 8:48 [PATCH] Introduce __fill_user() and kill __bzero() Franck Bui-Huu
2007-11-11 13:01 ` Thiemo Seufer
2007-11-11 13:57 ` Franck Bui-Huu
2007-11-14 8:24 ` Franck Bui-Huu
2007-11-14 11:58 ` Thiemo Seufer
2007-11-14 12:34 ` Franck Bui-Huu [this message]
2007-11-14 13:48 ` Thiemo Seufer
2007-11-14 15:13 ` Franck Bui-Huu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473AEB52.40501@gmail.com \
--to=vagabon.xyz@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.