Re: [PATCH] kvm: Fix accounting of interrupts during guest execution on s390

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Christian Borntraeger wrote:
> Am Mittwoch, 14. November 2007 schrieb Ingo Molnar:
>   
>> * Christian Borntraeger <borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> wrote:
>>
>>     
>>> Avi, Ingo, Laurent,
>>>
>>> what do you think about the following patch?
>>>       
>> fine to me. I guess this should mostly be a NOP to KVM, right?
>>     
>
> Yes, currently kvm on x86 has interrupts disabled during vmx and svm. So
> in_interrupt should be always false on x86.
>   
But isn't account_system_time() called via the timer tick interrupt, and 
never directly from kvm?  So in_interrupt() would always be true.


The sequence, as I understand it, is:

  - disable interrupts
  - set PF_VCPU
  - switch to guest
  - exit guest due to timer tick
  - enable interrupts
  - dispatch timer tick
  - account_system_time()

With the fine-grained accounting ppc and s390 have, this is different.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/