From: Chuck Lever <chuck.lever@oracle.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: nfs@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 05/25] NFS: eliminate NIPQUAD(clp->cl_addr.sin_addr)
Date: Wed, 14 Nov 2007 11:52:49 -0500 [thread overview]
Message-ID: <473B27E1.7020502@oracle.com> (raw)
In-Reply-To: <20071114.104533.127429382.yoshfuji@linux-ipv6.org>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
YOSHIFUJI Hideaki / 吉藤英明 wrote:
> In article <20071113183126.5087.27810.stgit@manray.1015granger.net> (at Tue, 13 Nov 2007 13:31:27 -0500), Chuck Lever <chuck.lever@oracle.com> says:
>
>> clp->rpc_ops->version,
>> - NIPQUAD(clp->cl_addr.sin_addr),
>> - ntohs(clp->cl_addr.sin_port),
>> + rpc_peeraddr2str(clp->cl_rpcclient, RPC_DISPLAY_HEX_ADDR),
>> + rpc_peeraddr2str(clp->cl_rpcclient, RPC_DISPLAY_HEX_PORT),
>> atomic_read(&clp->cl_count),
>
> Is this really safe?
What's unsafe about it? rpc_peeraddr2str() is designed to be called
this way.
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 270 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard
prev parent reply other threads:[~2007-11-14 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 18:31 [PATCH 05/25] NFS: eliminate NIPQUAD(clp->cl_addr.sin_addr) Chuck Lever
2007-11-14 1:45 ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-14 16:52 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473B27E1.7020502@oracle.com \
--to=chuck.lever@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.