From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabio Massimo Di Nitto <fabbione@ubuntu.com>
Date: Thu, 15 Nov 2007 16:06:12 +0100
Subject: [Cluster-devel] [PATCH] gfs2: tidy up error message
In-Reply-To: <20071115150113.GA8844@redhat.com>
References: <20071115150113.GA8844@redhat.com>
Message-ID: <473C6064.1030201@ubuntu.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>

David Teigland wrote:
> Print error with log_error() to be consistent with others.
> 
> Signed-off-by: David Teigland <teigland@redhat.com>
> ---
>  fs/gfs2/locking/dlm/mount.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/gfs2/locking/dlm/mount.c b/fs/gfs2/locking/dlm/mount.c
> index ab30102..f2efff4 100644
> --- a/fs/gfs2/locking/dlm/mount.c
> +++ b/fs/gfs2/locking/dlm/mount.c
> @@ -68,8 +68,7 @@ static int make_args(struct gdlm_ls *ls, char *data_arg, int *nodir)
>  	strncpy(data, data_arg, 255);
>  
>  	if (!strlen(data)) {
> -		printk(KERN_ERR
> -		       "DLM/GFS2/GFS ERROR: (u)mount helpers are not installed!\n");
> +		log_error("no mount options, (u)mount helpers not installed");
>  		return -EINVAL;
>  	}
>  


-- 
I'm going to make him an offer he can't refuse.