All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Battersby <tonyb@cybernetics.com>
To: Matthew Wilcox <matthew@wil.cx>, linux-scsi@vger.kernel.org
Subject: [PATCH] [SCSI] sym53c8xx: increase sg_tablesize for larger data transfers
Date: Thu, 15 Nov 2007 10:06:44 -0500	[thread overview]
Message-ID: <473C6084.2040700@cybernetics.com> (raw)

This patch increases the sg_tablesize for sym53c8xx from 96 to 128,
which enables commands to transfer larger amounts of data (e.g. 512 KB
instead of 384 KB, assuming 4 KB non-adjacent pages).

In the current design of sym53c8xx, SYM_CONF_MAX_SG must be set low
enough so that (sym_fw1.a_size <= PAGE_SIZE) && (sym_fw2.a_size <=
PAGE_SIZE).  With SYM_CONF_MAX_SG == 128, sym_fw1.a_size == 3940 and
sym_fw2.a_size == 3576 (plus or minus a few bytes depending on other
configuration options).  The a_size values increase by 16 for every
additional sg vector, so SYM_CONF_MAX_SG cannot be set much higher than
128 without making more intrusive changes.

Tested on a LSI 53c1010-66.

Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
---
--- linux-2.6.24-rc2-git5/drivers/scsi/sym53c8xx_2/sym53c8xx.h.orig	2007-11-15 09:36:03.000000000 -0500
+++ linux-2.6.24-rc2-git5/drivers/scsi/sym53c8xx_2/sym53c8xx.h	2007-11-15 09:36:11.000000000 -0500
@@ -106,7 +106,7 @@
 /*
  *  Max number of SG entries.
  */
-#define SYM_CONF_MAX_SG		(96)
+#define SYM_CONF_MAX_SG		(128)
 
 /*
  *  Driver setup structure.



             reply	other threads:[~2007-11-15 15:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15 15:06 Tony Battersby [this message]
2007-11-15 16:10 ` [PATCH] [SCSI] sym53c8xx: increase sg_tablesize for larger data transfers James Bottomley
2007-11-15 16:38   ` Tony Battersby
2007-11-15 16:57     ` James Bottomley
2007-11-15 19:57       ` Tony Battersby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473C6084.2040700@cybernetics.com \
    --to=tonyb@cybernetics.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.