From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chuck Lever Subject: Re: Use of delayed request information in nlmsvc_lookup_host Date: Thu, 15 Nov 2007 11:26:44 -0500 Message-ID: <473C7344.5090705@oracle.com> References: <473B3D0B.3060204@oracle.com> <1195065798.7584.37.camel@heimdal.trondhjem.org> <473B45C9.4060708@oracle.com> <1195069262.7584.54.camel@heimdal.trondhjem.org> <473B5278.7090408@oracle.com> <18235.41907.383911.722103@notabene.brown> <473C4FE2.1090402@oracle.com> <1195142050.7506.13.camel@heimdal.trondhjem.org> Reply-To: chuck.lever@oracle.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050509000905050307000408" Cc: Neil Brown , nfs@lists.sourceforge.net To: Trond Myklebust Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1IshdL-0006P2-6n for nfs@lists.sourceforge.net; Thu, 15 Nov 2007 08:32:03 -0800 Received: from rgminet01.oracle.com ([148.87.113.118]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1Isha2-0002xA-8r for nfs@lists.sourceforge.net; Thu, 15 Nov 2007 08:28:38 -0800 In-Reply-To: <1195142050.7506.13.camel@heimdal.trondhjem.org> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net This is a multi-part message in MIME format. --------------050509000905050307000408 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Trond Myklebust wrote: > On Thu, 2007-11-15 at 08:55 -0500, Chuck Lever wrote: > >> What do you think of changing the rq_daddr field to be a sockaddr_storage? > > Why? You've already got rq_addr. rq_daddr stores raw address bits, but nlm_host stores a whole sockaddr for the source address. Should we change nlm_host to store just the raw address bits as well (svc_addr_u)? AFAICS the only place that needs to construct a whole sockaddr out of the source address is nlm_bind_host. In addition, NSM_NOTIFY gets a 4-byte address off the wire, and assumes it's AF_INET. Should we store this in an in_addr/in_addr6 union as well? I haven't looked closely at NSM_NOTIFY... is it even possible to send a non-AF_INET address with this procedure? --------------050509000905050307000408 Content-Type: text/x-vcard; charset=utf-8; name="chuck.lever.vcf" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="chuck.lever.vcf" begin:vcard fn:Chuck Lever n:Lever;Chuck org:Oracle Corporation;Corporate Architecture: Linux Projects Group adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA title:Principal Member of Staff tel;work:+1 248 614 5091 x-mozilla-html:FALSE version:2.1 end:vcard --------------050509000905050307000408 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --------------050509000905050307000408 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs --------------050509000905050307000408--