All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chris Friesen" <cfriesen@nortel.com>
To: "Moore, Eric" <Eric.Moore@lsi.com>
Cc: "Stephens, Larry" <Larry.Stephens@lsi.com>,
	linux-scsi@vger.kernel.org, dgilbert@interlog.com,
	James.Bottomley@SteelEye.com,
	DL-MPT Fusion Linux <DL-MPTFusionLinux@lsi.com>
Subject: Re: how to handle QUEUE_FULL/SAM_STAT_TASK_SET_FULL in userspace?
Date: Thu, 15 Nov 2007 13:09:46 -0600	[thread overview]
Message-ID: <473C997A.90404@nortel.com> (raw)
In-Reply-To: <664A4EBB07F29743873A87CF62C26D70B3443F@NAMAIL4.ad.lsil.com>

Moore, Eric wrote:

> You already figured out the problem, I don't understand why your asking
> if the kernel verison is behaving properly.   You said between those
> driver versions the device queue depth increased from 32 to 64, and that
> is exactly what happened.   The reason for the increase is some customer
> ask for the increase queue_depth which helps with performance. We are
> not going to decrease it back.

My impression is that the per-device queue is supposed to be decreased 
at runtime to match the actual size that the hardware can handle.  In 
the earlier version we're seeing the queue set to 7 at runtime, while 
the more recent version is showing a queue depth of 32 or 64 and is 
giving QUEUE_FULL errors to the userspace apps.

I just wanted to make sure that 2.6.14 was working correctly (ie, this 
wasn't a bug that has been fixed in a more recent version).

> SAM_STAT_TASK_SET_FULL in /usr/src/linux/scsi/scsi.h, is the same as
> QUEUE_FULL.  If you look in scsi_error.c searching for QUEUE_FULL, you
> will see that it will translate to ADD_TO_MLQUEUE, which means it will
> reposted to the request queue.

I don't know the scsi code very well, so maybe I'm missing something 
obvious here.  If so, I apologize.

Our userspace apps are getting a status of TASK_SET_FULL on completion 
of an ioctl() call.

Does this status mean that the command needs to be retried by the 
userspace app, that it has already been retried by the lower levels and 
is now completed, or something else entirely?

Thanks,

Chris

  reply	other threads:[~2007-11-15 19:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12 19:54 how to handle QUEUE_FULL/SAM_STAT_TASK_SET_FULL in userspace? Chris Friesen
2007-11-13 22:04 ` Chris Friesen
2007-11-13 22:34   ` Moore, Eric
2007-11-14 17:23     ` Chris Friesen
2007-11-14 22:45       ` Moore, Eric
2007-11-15 19:09         ` Chris Friesen [this message]
2007-11-15 19:43           ` James Smart
2007-11-15 19:59             ` Moore, Eric
2007-11-15 19:57           ` Moore, Eric
2007-11-15 21:59             ` Chris Friesen
2007-11-15 22:18               ` James Bottomley
2007-11-15 22:35                 ` Moore, Eric
2007-11-15 22:47                   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473C997A.90404@nortel.com \
    --to=cfriesen@nortel.com \
    --cc=DL-MPTFusionLinux@lsi.com \
    --cc=Eric.Moore@lsi.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=Larry.Stephens@lsi.com \
    --cc=dgilbert@interlog.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.