From: Lucy McCoy <lucy@keyspan.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: bbpetkov@yahoo.de, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keyspan: init termios properly
Date: Thu, 15 Nov 2007 12:28:23 -0800 [thread overview]
Message-ID: <473CABE7.5030205@keyspan.com> (raw)
In-Reply-To: <20071115120909.133e8e52.akpm@linux-foundation.org>
Yes, it will break things. I'll try to get to it soon...
Andrew Morton wrote:
> On Thu, 15 Nov 2007 09:49:22 -0800 Lucy McCoy <lucy@keyspan.com> wrote:
>
>
>> Greg & Boris,
>>
>> I've been out of town and just saw this.
>>
>> This patch will work with the 19HS but WILL BREAK all other Keyspan
>> adapters. It will take me a few days to get to looking at a correct fix but
>> that keyspan_send_setup(port, 1) (and the '1' is the important part)
>> must happen once
>> when the port is first opened. The cflag can just be set to whatever
>> the normal default
>> is for your serial environment. What are the defaults?
>>
>>
>
> drat, this patch just went into mainline.
>
> If you're sure that it'll break things, I'll revert it while you cook up
> something better, OK?
>
>
>
next prev parent reply other threads:[~2007-11-15 20:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 10:03 [PATCH] keyspan: init termios properly Borislav Petkov
2007-11-15 17:49 ` Lucy McCoy
2007-11-15 20:09 ` Andrew Morton
2007-11-15 20:28 ` Lucy McCoy [this message]
2007-11-15 20:40 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2007-11-15 21:10 Lucy McCoy
2007-11-16 6:24 ` Borislav Petkov
2007-11-18 13:11 ` Borislav Petkov
2007-11-26 22:18 ` Andrew Morton
2007-11-30 5:45 ` Borislav Petkov
2007-11-30 17:23 ` Lucy McCoy
2007-12-02 8:03 ` Borislav Petkov
2007-12-02 13:57 ` Alan Cox
2007-12-02 17:40 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473CABE7.5030205@keyspan.com \
--to=lucy@keyspan.com \
--cc=akpm@linux-foundation.org \
--cc=bbpetkov@yahoo.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.