From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Thiemo Seufer <ths@networkno.de>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH] Introduce __fill_user() and kill __bzero() [take #2]
Date: Thu, 15 Nov 2007 22:16:23 +0100 [thread overview]
Message-ID: <473CB727.8010106@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711151744580.31039@anakin>
Geert Uytterhoeven wrote:
> On Thu, 15 Nov 2007, Franck Bui-Huu wrote:
>> I put the out of line version of memset in kernel/mips_ksym.c. I
>> haven't found a better place. But if you really think we should
>> create a lib/memset.c and rename lib/memset.S into lib/fill_user.S, I
>> can change it.
>
> kernel/mips_ksym.c is not a good place.
Sigh... thanks for spotting this.
So since I've no idea where I could put this function I'll follow
Thiemo's suggestion but instead of calling the new file lib/memset.c,
I'll use lib/string.c since we could move or implement other stuffs in
it.
Is it ok ?
Franck
next prev parent reply other threads:[~2007-11-15 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 16:21 [PATCH] Introduce __fill_user() and kill __bzero() [take #2] Franck Bui-Huu
2007-11-15 16:46 ` Geert Uytterhoeven
2007-11-15 21:16 ` Franck Bui-Huu [this message]
2007-11-15 22:09 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473CB727.8010106@gmail.com \
--to=vagabon.xyz@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=ths@networkno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.