From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: johnpol@2ka.mipt.ru, cebbert@redhat.com,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Null pointer dereference in nf_nat_move_storage(), kernel 2.6.23.1
Date: Fri, 16 Nov 2007 01:00:22 +0100 [thread overview]
Message-ID: <473CDD96.6090102@trash.net> (raw)
In-Reply-To: <20071115.155509.107545186.davem@davemloft.net>
David Miller wrote:
> From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
> Date: Thu, 15 Nov 2007 15:06:59 +0300
>
>> Please test attached patch.
>>
>> This routing is called each time hash should be replaced, nf_conn has
>> extension list which contains pointers to connection tracking users
>> (like nat, which is right now the only such user), so when replace takes
>> place it should copy own extensions. Loop above checks for own
>> extension, but tries to move higer-layer one, which can lead to above
>> oops.
>>
>> Not tested, derived from code observation only.
>>
>> Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
>
> It looks extremely correct to me. Therefore I'm going to apply
> this and queue it up for -stable.
>
> Thanks Evgeniy, keep up the excellent work!
>
> Patrick, please let me know if you have any objections.
The patch looks fine, thanks. I was just waiting for confirmation
from Chuck.
next prev parent reply other threads:[~2007-11-16 0:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 18:03 Null pointer dereference in nf_nat_move_storage(), kernel 2.6.23.1 Chuck Ebbert
2007-11-14 23:25 ` Chuck Ebbert
2007-11-15 12:06 ` Evgeniy Polyakov
2007-11-15 23:55 ` David Miller
2007-11-16 0:00 ` Patrick McHardy [this message]
2007-11-16 0:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473CDD96.6090102@trash.net \
--to=kaber@trash.net \
--cc=cebbert@redhat.com \
--cc=davem@davemloft.net \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.