From: "Denis V. Lunev" <den-3ImXcnM4P+0@public.gmane.org>
To: dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org
Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org
Subject: Re: [patch 1/1][NETNS] fix fib_frontend compilation error
Date: Fri, 16 Nov 2007 14:33:50 +0300 [thread overview]
Message-ID: <473D801E.2030909@sw.ru> (raw)
In-Reply-To: <20071114142523.283777897-WECHFHqYCmGD/CxQmPlnQ0FT0OZdM7KVQQ4Iyu8u01E@public.gmane.org>
apparently, the patch is not enough, fib4_rules_init is called from
non-init function. I'll drop this one during port to 2.6.25 tree
dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org wrote:
> Added net namespace parameter to fib4_rules_init when statically
> defined in fib_frontend.c
>
> Signed-off-by: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
> ---
> net/ipv4/fib_frontend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-netns/net/ipv4/fib_frontend.c
> ===================================================================
> --- linux-2.6-netns.orig/net/ipv4/fib_frontend.c
> +++ linux-2.6-netns/net/ipv4/fib_frontend.c
> @@ -59,7 +59,7 @@ struct fib_table *ip_fib_main_table;
> #define FIB_TABLE_HASHSZ 1
> static struct hlist_head fib_table_hash[FIB_TABLE_HASHSZ];
>
> -static void __init fib4_rules_init(void)
> +static void __init fib4_rules_init(struct net *net)
> {
> ip_fib_local_table = fib_hash_init(RT_TABLE_LOCAL);
> hlist_add_head_rcu(&ip_fib_local_table->tb_hlist, &fib_table_hash[0]);
>
prev parent reply other threads:[~2007-11-16 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071114142443.794857293@mai.toulouse-stg.fr.ibm.com>
2007-11-14 14:24 ` [patch 1/1][NETNS] fix fib_frontend compilation error dlezcano-NmTC/0ZBporQT0dZR+AlfA
[not found] ` <20071114142523.283777897-WECHFHqYCmGD/CxQmPlnQ0FT0OZdM7KVQQ4Iyu8u01E@public.gmane.org>
2007-11-14 16:16 ` Denis V. Lunev
[not found] ` <473B1F63.5040105-3ImXcnM4P+0@public.gmane.org>
2007-11-14 16:18 ` Daniel Lezcano
[not found] ` <473B1FC2.9030003-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-11-15 13:31 ` Eric W. Biederman
2007-11-16 11:33 ` Denis V. Lunev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473D801E.2030909@sw.ru \
--to=den-3imxcnm4p+0@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.