From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: netns refcounting Date: Fri, 16 Nov 2007 16:50:13 +0100 Message-ID: <473DBC35.6090100@fr.ibm.com> References: <473DA358.9040705@sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <473DA358.9040705-3ImXcnM4P+0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Denis V. Lunev" Cc: Linux Containers , "Eric W. Biederman" , Pavel Emelianov List-Id: containers.vger.kernel.org Denis V. Lunev wrote: > Hello, All! > > During port of Eric's patches I have noticed an interesting thing. > The patch "net: Teach the ipv4 route cache to handle multiple network > namespaces" call hold_net for each IPv4 DST cache entry. > > Though it is not possible to stop a namespace without stopping all the > devices inside. Additionally, the device can't be unregistered if there > are dst entries to it. These entries are moved to a namespace loopback > and the namespace will block until these entries will gone from a loopback. > > So, I do not see a necessity to have an extra atomic on this hot path, > i.e. hold_net can re moved away for this. Are there any holes? That seems reasonable to remove, good catch.