All of lore.kernel.org
 help / color / mirror / Atom feed
From: Franck Bui-Huu <vagabon.xyz@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pm@lists.linux-foundation.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: apm emulation driver broken ?
Date: Sat, 17 Nov 2007 09:53:46 +0100	[thread overview]
Message-ID: <473EAC1A.1000205@gmail.com> (raw)
In-Reply-To: <200711162220.56494.rjw@sisk.pl>

Rafael J. Wysocki wrote:
> However, using PF_NOFREEZE to prevent this from happening doesn't seem to be
> a good idea.
> 

Indeed but...

> I'd probably use wait_event_freezable() (defined in
> include/linux/freezer.h) for that.

...I would just revert this bits from now to make sure this driver
work again for v2.6.24.
 
> It tries to send them fake signals and waits for them to freeze.  If
> they don't freeze within the timeout, it fails and clears their
> TIF_FREEZE bits.

But send_fake_signal() seems to wake up task in INTERRUPTIBLE state
only. Looking at signal_wake_up(), it basically do:

	wake_up_state(t, TASK_INTERRUPTIBLE);

What am I missing ?

		Franck


  reply	other threads:[~2007-11-17  8:54 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-16 15:06 apm emulation driver broken ? Franck Bui-Huu
2007-11-16 16:20 ` Rafael J. Wysocki
2007-11-16 17:29   ` Franck Bui-Huu
2007-11-16 21:20     ` Rafael J. Wysocki
2007-11-17  8:53       ` Franck Bui-Huu [this message]
2007-11-17  9:59         ` Rafael J. Wysocki
2007-11-17  9:59         ` Rafael J. Wysocki
2007-11-17 11:09           ` Rafael J. Wysocki
2007-11-17 11:09           ` Rafael J. Wysocki
2007-11-17 11:57           ` Franck Bui-Huu
2007-11-17 11:57           ` Franck Bui-Huu
2007-11-17 12:46             ` Rafael J. Wysocki
2007-11-18 19:57               ` Franck Bui-Huu
2007-11-18 22:22                 ` Rafael J. Wysocki
2007-11-18 22:22                 ` Rafael J. Wysocki
2007-11-19 13:05                   ` Franck Bui-Huu
2007-11-21  1:32                     ` Rafael J. Wysocki
2007-11-19 13:05                   ` Franck Bui-Huu
2007-11-18 19:57               ` Franck Bui-Huu
2007-11-17 12:46             ` Rafael J. Wysocki
2007-11-17  8:53       ` Franck Bui-Huu
2007-11-16 21:20     ` Rafael J. Wysocki
2007-11-16 17:29   ` Franck Bui-Huu
2007-11-16 16:20 ` Rafael J. Wysocki
  -- strict thread matches above, loose matches on Subject: below --
2007-11-16 15:06 Franck Bui-Huu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473EAC1A.1000205@gmail.com \
    --to=vagabon.xyz@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.