From: "Gregory Haskins" <ghaskins@novell.com>
To: "Steven Rostedt" <rostedt@goodmis.org>,
"LKML" <linux-kernel@vger.kernel.org>
Cc: "Peter Zijlstra" <a.p.zijlstra@chello.nl>,
"Ingo Molnar" <mingo@elte.hu>,
"Christoph Lameter" <clameter@sgi.com>
Subject: Re: [PATCH v3 17/17] (Avoid overload)
Date: Sat, 17 Nov 2007 12:46:54 -0500 [thread overview]
Message-ID: <473EE2BE.BA47.005A.0@novell.com> (raw)
In-Reply-To: <20071117063318.GA31442@goodmis.org>
>>> On Sat, Nov 17, 2007 at 1:33 AM, in message
<20071117063318.GA31442@goodmis.org>, Steven Rostedt <rostedt@goodmis.org>
wrote:
> - if ((p->prio >= rq->rt.highest_prio)
> - && (p->nr_cpus_allowed > 1)) {
> + if (unlikely(rt_task(rq->curr))) {
> int cpu = find_lowest_rq(p);
>
> return (cpu == -1) ? task_cpu(p) : cpu;
We probably should leave the "p->nr_cpus_allowed > 1" in the conditional since it doesn't make sense to look if the task can't go anywhere.
-Greg
next prev parent reply other threads:[~2007-11-17 17:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 6:21 [PATCH v3 00/17] New RT Task Balancing -v3 Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 01/17] Add rt_nr_running accounting Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 02/17] track highest prio queued on runqueue Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 03/17] push RT tasks Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 04/17] RT overloaded runqueues accounting Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 05/17] pull RT tasks Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 06/17] wake up balance RT Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 07/17] disable CFS RT load balancing Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 08/17] Cache cpus_allowed weight for optimizing migration Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 09/17] Consistency cleanup for this_rq usage Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 10/17] Remove some CFS specific code from the wakeup path of RT tasks Steven Rostedt
2007-11-17 17:35 ` Gregory Haskins
2007-11-17 18:51 ` Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 11/17] RT: Break out the search function Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 12/17] Allow current_cpu to be included in search Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 13/17] RT: Pre-route RT tasks on wakeup Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 14/17] Optimize our cpu selection based on topology Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 15/17] RT: Optimize rebalancing Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 16/17] Fix schedstat handling Steven Rostedt
2007-11-17 17:40 ` Gregory Haskins
2007-11-17 18:52 ` Steven Rostedt
2007-11-17 6:21 ` [PATCH v3 17/17] --- kernel/sched_rt.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) Steven Rostedt
2007-11-17 6:33 ` [PATCH v3 17/17] (Avoid overload) Steven Rostedt
2007-11-17 17:42 ` Gregory Haskins
2007-11-17 18:55 ` Steven Rostedt
2007-11-17 17:46 ` Gregory Haskins [this message]
2007-11-19 16:34 ` [PATCH] RT: restore the migratable conditional Gregory Haskins
2007-11-17 8:14 ` [PATCH v3 00/17] New RT Task Balancing -v3 Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473EE2BE.BA47.005A.0@novell.com \
--to=ghaskins@novell.com \
--cc=a.p.zijlstra@chello.nl \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.