All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Neuling <mikey@neuling.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, Ian Munsie <imunsie@au1.ibm.com>,
	Matt Evans <matt@ozlabs.org>
Subject: Re: [PATCH 09/14] powerpc: Setup relocation on exceptions for bare metal systems
Date: Mon, 12 Nov 2012 13:08:59 +1100	[thread overview]
Message-ID: <474.1352686139@neuling.org> (raw)
In-Reply-To: <B2250515-36A9-4826-B50B-49298A28FB39@kernel.crashing.org>

Segher Boessenkool <segher@kernel.crashing.org> wrote:

> > --- a/arch/powerpc/include/asm/reg.h
> > +++ b/arch/powerpc/include/asm/reg.h
> > @@ -249,6 +249,8 @@
> >  #define   LPCR_RMLS    0x1C000000      /* impl dependent rmo limit sel */
> >  #define	  LPCR_RMLS_SH	(63-37)
> >  #define   LPCR_ILE     0x02000000      /* !HV irqs set MSR:LE */
> > +#define   LPCR_AIL_0	0x00000000	/* MMU off IRQ location 0x0 */
> > +#define   LPCR_AIL_3	0x01800000	/* MMU on IRQ location 0xc00...4xxx */
> 
> s/IRQ location/exception offset/ ?

Sure, updated.

> 
> > --- a/arch/powerpc/kernel/cpu_setup_power.S
> > +++ b/arch/powerpc/kernel/cpu_setup_power.S
> > @@ -54,6 +54,7 @@ _GLOBAL(__setup_cpu_power8)
> >  	li	r0,0
> >  	mtspr	SPRN_LPID,r0
> >  	mfspr	r3,SPRN_LPCR
> > +	oris	r3, r3, LPCR_AIL_3@h
> 
> Is the AIL field only two bits?  If not, you probably want to clear
> the other bits.

Yes it only 2 bits.

> This series looks really nice btw :-)

Cheers,
Mikey

  reply	other threads:[~2012-11-12  2:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09  6:18 [PATCH 00/14] powerpc: Add support for POWER8 relocation on exceptions Michael Neuling
2012-11-09  6:18 ` [PATCH 01/14] powerpc: Fix name denorm hypervisor symbol Michael Neuling
2012-11-09  6:19 ` [PATCH 02/14] powerpc: Whitespace changes in exception64s.S Michael Neuling
2012-11-09  6:19 ` [PATCH 03/14] powerpc: Remove unessessary 0x3000 location enforcement Michael Neuling
2012-11-09  6:19 ` [PATCH 04/14] powerpc: Make load_hander handle upto 64k offset Michael Neuling
2012-11-09  6:19 ` [PATCH 05/14] powerpc: Turn syscall handler into macros Michael Neuling
2012-11-09  6:19 ` [PATCH 06/14] powerpc: Add new macros needed for relocation on exceptions Michael Neuling
2012-11-09  6:19 ` [PATCH 07/14] powerpc: Add relocation on exception vector handlers Michael Neuling
2012-11-09  6:19 ` [PATCH 08/14] powerpc: Move initial mfspr LPCR out of __init_LPCR Michael Neuling
2012-11-09  6:19 ` [PATCH 09/14] powerpc: Setup relocation on exceptions for bare metal systems Michael Neuling
2012-11-12  1:32   ` Segher Boessenkool
2012-11-12  2:08     ` Michael Neuling [this message]
2012-11-09  6:19 ` [PATCH 10/14] powerpc: Add set_mode hcall Michael Neuling
2012-11-09  6:19 ` [PATCH 10/12] powerpc: Move get_longbusy_msecs into hvcall.h and remove duplicate function Michael Neuling
2012-11-09  6:19 ` [PATCH 11/14] powerpc: Add wrappers to enable/disable relocation on exceptions Michael Neuling
2012-11-09  6:19 ` [PATCH 12/14] powerpc: Move get_longbusy_msecs into hvcall.h and remove duplicate function Michael Neuling
2012-11-09  9:26   ` Stephen Rothwell
2012-11-09  9:49     ` Michael Neuling
2012-11-09  6:19 ` [PATCH 13/14] powerpc: Enable relocation on during exceptions at boot Michael Neuling
2012-11-09  6:19 ` [PATCH 14/14] powerpc: Disable relocation on exceptions when kexecing Michael Neuling
2012-11-09  8:58 ` [PATCH 00/14] powerpc: Add support for POWER8 relocation on exceptions Gabriel Paubert
2012-11-09  9:51   ` Michael Neuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474.1352686139@neuling.org \
    --to=mikey@neuling.org \
    --cc=imunsie@au1.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=matt@ozlabs.org \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.