All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Girdwood, Liam" <lrg@ti.com>,
	"Lopez Cruz, Misael" <misael.lopez@ti.com>
Subject: Re: [PATCH v3 2/3] ASoC: soc-dapm: API to attach DAPM_SUPPLY to be used for dai
Date: Mon, 29 Aug 2011 11:22:52 +0300	[thread overview]
Message-ID: <4740107.jCnGMjlvlq@barack> (raw)
In-Reply-To: <20110826190420.GA2943@opensource.wolfsonmicro.com>

On Friday 26 August 2011 21:05:02 Mark Brown wrote:
> This wasn't really what I meant - what I meant was that we ought to be
> able to change the ordering of DAPM with regard to the stream shutdown
> without having to have anything more than flags in the devices that can
> or need to do it (I'd expect more the CODECs more than the CPUs).

I see, but this is not what I'm trying to achieve here.
Even, if we could re-order the stream shutdown (for DAIs mostly) and DAPM 
sequence it won't work for me:
I need to make sure that the cpu_dai (McPDM) is shut down _after the DAC/ADC, 
and _before_ the codec is powered down - which would stop the McPDM clocks - 
which in turn used by McPDM as functional clock.
So if we would somehow execute the DAPM first followed by the stream shutdown, 
I can be in a situation, when McPDM is not accessible (missing clocks).

If we really want to reorder the stream shutdown and DAPM, we need to quite a 
bit of change, since we need to be able to 'delay' the shutdown operations for 
DAIs/platforms at least. But. Since the stream has been already closed, we can 
not refer to it anymore in case of pmdown_time > 0 (playback only issue).

One way would be to have special DAPM widget for DAI/platform event, and hook 
that up somewhere at some point that it will do what it is intended to be 
doing.
Or some callback function for DAIs/platforms, which would be called from the  
dapm_power_widgets function.

These would work, mostly, but I'm not convinced, that it would work for me, so 
I anyway need to do something similar as in this series.

--
Péter

  reply	other threads:[~2011-08-29  8:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 13:33 [PATCH v3 0/3] ASoC: omap-mcpdm: New McPDM driver Peter Ujfalusi
2011-08-26 13:33 ` [PATCH v3 1/3] ASoC: DAPM: Add private data pointer for DAPM widget Peter Ujfalusi
2011-08-26 13:33 ` [PATCH v3 2/3] ASoC: soc-dapm: API to attach DAPM_SUPPLY to be used for dai Peter Ujfalusi
2011-08-26 19:05   ` Mark Brown
2011-08-29  8:22     ` Péter Ujfalusi [this message]
2011-08-29  9:16       ` Mark Brown
2011-08-29 11:41         ` Péter Ujfalusi
2011-09-03  6:31           ` Mark Brown
2011-09-06 10:21             ` Péter Ujfalusi
2011-09-06 15:09               ` Mark Brown
2011-08-26 13:33 ` [PATCH v3 3/3] ASoC: omap-mcpdm: Replace legacy driver Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4740107.jCnGMjlvlq@barack \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@ti.com \
    --cc=misael.lopez@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.