From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ItpAa-0006Hf-I1 for mharc-grub-devel@gnu.org; Sun, 18 Nov 2007 13:47:00 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ItpAY-0006Fp-Ny for grub-devel@gnu.org; Sun, 18 Nov 2007 13:46:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ItpAW-0006Dv-V2 for grub-devel@gnu.org; Sun, 18 Nov 2007 13:46:58 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItpAW-0006Dh-P5 for grub-devel@gnu.org; Sun, 18 Nov 2007 13:46:56 -0500 Received: from mailout07.sul.t-online.de ([194.25.134.83] helo=mailout07.sul.t-online.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ItpAW-0001ia-Ch for grub-devel@gnu.org; Sun, 18 Nov 2007 13:46:56 -0500 Received: from fwd27.aul.t-online.de by mailout07.sul.t-online.com with smtp id 1ItpAV-0004jZ-01; Sun, 18 Nov 2007 19:46:55 +0100 Received: from [10.3.2.2] (JlrRYUZrQhxgrhjtKDmmfsuQs4hW-fFjig+U-dMqZly9MUJ3XnCs3-YyJumiSZsQRs@[217.235.218.178]) by fwd27.aul.t-online.de with esmtp id 1ItpAO-19s5Xk0; Sun, 18 Nov 2007 19:46:48 +0100 Message-ID: <47408899.7080308@t-online.de> Date: Sun, 18 Nov 2007 19:46:49 +0100 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: The development of GRUB 2 References: <473A0C32.5000001@t-online.de> <87wssfrdsm.fsf@xs4all.nl> In-Reply-To: <87wssfrdsm.fsf@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: JlrRYUZrQhxgrhjtKDmmfsuQs4hW-fFjig+U-dMqZly9MUJ3XnCs3-YyJumiSZsQRs X-TOI-MSGID: b949ff50-fef2-4004-95cc-60f8e3df8cca X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] mkdevicemap for Cygwin X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2007 18:46:59 -0000 Marco Gerards wrote: > Christian Franke writes: > > >> Some changes for grub-mkdevicemap on Cygwin. >> >> Christian >> >> 2007-11-13 Christian Franke >> >> * util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin >> device names. >> (get_ide_disk_name): Disable on __CYGWIN__. >> > > [__CYGWIN__] (get_ide_disk_name): Disable. > > >> (get_scsi_disk_name): Add Cygwin device names. >> (check_device): Add static. >> Return error instead of success on empty string. >> > > Can you explain this? Does this break something on GNU/Linux? > > See last mail. Should not break GNU/Linux, because (*name = 0) is not used then. >> (make_device_map): Disable IDE loop on __CYGWIN__. >> > > [__CYGWIN__] (make_device_map): Disable IDE loop. > > >> Move label inside linux specific code to prevent compiler warning. >> > > (make_device_map): Move label inside linux specific code to > prevent compiler warning. > > Otherwise fine, so this can be committed if there aren't any other > problems with this patch. > Thanks, new changelog below. Christian 2007-11-18 Christian Franke * util/grub-mkdevicemap.c (get_floppy_disk_name): Add Cygwin device names. [__CYGWIN__] (get_ide_disk_name): Disable. (get_scsi_disk_name): Add Cygwin device names. (check_device): Add static. Return error instead of success on empty string. [__CYGWIN__] (make_device_map): Disable IDE loop. (make_device_map): Move label inside linux specific code to prevent compiler warning.