From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Itr8O-0003vb-7U for mharc-grub-devel@gnu.org; Sun, 18 Nov 2007 15:52:52 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Itr8N-0003vM-8v for grub-devel@gnu.org; Sun, 18 Nov 2007 15:52:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Itr8K-0003uu-Qf for grub-devel@gnu.org; Sun, 18 Nov 2007 15:52:49 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Itr8K-0003ur-Ki for grub-devel@gnu.org; Sun, 18 Nov 2007 15:52:48 -0500 Received: from mailout04.sul.t-online.de ([194.25.134.18] helo=mailout04.sul.t-online.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Itr8J-0000P3-V0 for grub-devel@gnu.org; Sun, 18 Nov 2007 15:52:48 -0500 Received: from fwd27.aul.t-online.de by mailout04.sul.t-online.com with smtp id 1Itr8I-0004jq-03; Sun, 18 Nov 2007 21:52:46 +0100 Received: from [10.3.2.2] (SyCEAQZZ8hLgP3lqQBIDsPzqUTUWyaIwtnUnNk3J3HSxgOXMZwBodxD1y934v2qgYY@[217.235.218.178]) by fwd27.aul.t-online.de with esmtp id 1Itr8B-1dlkEC0; Sun, 18 Nov 2007 21:52:39 +0100 Message-ID: <4740A618.2060701@t-online.de> Date: Sun, 18 Nov 2007 21:52:40 +0100 From: Christian Franke User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: The development of GRUB 2 References: <4736009D.3010502@t-online.de> <20071110212421.GI15633@thorin> <473748F4.4070206@t-online.de> <20071118061841.GB20719@thorin> In-Reply-To: <20071118061841.GB20719@thorin> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ID: SyCEAQZZ8hLgP3lqQBIDsPzqUTUWyaIwtnUnNk3J3HSxgOXMZwBodxD1y934v2qgYY X-TOI-MSGID: b49517f6-f0b2-4ce7-afd0-0a4d6e17c5c9 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Handle C symbols with leading underscore (HAVE_ASM_USCORE) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2007 20:52:51 -0000 Robert Millan wrote: > >> diff -rup grub2.orig/kern/dl.c grub2/kern/dl.c >> --- grub2.orig/kern/dl.c 2007-07-22 01:32:26.000000000 +0200 >> +++ grub2/kern/dl.c 2007-11-11 18:01:50.578125000 +0100 >> @@ -53,6 +53,12 @@ typedef Elf64_Sym Elf_Sym; >> >> #endif >> >> +#ifdef HAVE_ASM_USCORE >> +# define SYM_USCORE "_" >> +#else >> +# define SYM_USCORE "" >> +#endif >> > > Should this be global? We already have START_SYMBOL and END_SYMBOL. Perhaps > this should be next to them? > > START_SYMBOL and END_SYMBOL are in config.h. SYM_USCORE is derived from a config.h symbol and therefore cannot be placed there without changing configure.ac. The symbol is (and likely will be) only used once, so it IMO makes no sense to declare it non-locally. Christian