From: Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
Cc: carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
Christian Ehrhardt
<EHRHARDT-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>,
Hollis Blanchard
<hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
"Zhang,
Xiantao" <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH][1/3] Move kvm_vcpu_iotcl_get_dirty_log to arch
Date: Mon, 19 Nov 2007 15:59:41 +0100 [thread overview]
Message-ID: <4741A4DD.5020503@de.ibm.com> (raw)
In-Reply-To: <4741A3FE.70908-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Carsten Otte wrote:
> Yea, I agree that it would make sense in case it works for power too. We
> could have an
> #ifdef CONFIG_ARCH_S390
> return cool_big_iron_get_dirty_log(args);
> #endif
> at the beginning of that function. It would'nt hurt readability too much.
Stupid suggestion. We could outsource the #ifdef to the caller, that
would be much cleaner.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2007-11-19 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 5:35 [PATCH][1/3] Move kvm_vcpu_iotcl_get_dirty_log to arch Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC9A0A7D-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-19 14:39 ` Carsten Otte
[not found] ` <4741A011.2080405-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-19 14:52 ` Avi Kivity
[not found] ` <4741A322.8040201-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-19 14:55 ` Carsten Otte
[not found] ` <4741A3FE.70908-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-19 14:59 ` Carsten Otte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4741A4DD.5020503@de.ibm.com \
--to=cotte-ta70fqpds9bqt0dzr+alfa@public.gmane.org \
--cc=EHRHARDT-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.