From: "Jiayuan Chen" <jiayuan.chen@linux.dev>
To: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
Cc: "bpf" <bpf@vger.kernel.org>, "Quentin Monnet" <qmo@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Song Liu" <song@kernel.org>,
"Yonghong Song" <yonghong.song@linux.dev>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
"LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v1] bpftool: Add support for custom BTF path in prog load/loadall
Date: Wed, 14 May 2025 01:51:14 +0000 [thread overview]
Message-ID: <4741dfb9fa4cf32cef28d9f2b7e7c2e788430800@linux.dev> (raw)
In-Reply-To: <CAADnVQJJ7pLsm0UTzPOj1H+rdaaY7Lv0As0Te-b+7zieQbntkw@mail.gmail.com>
2025/5/14 05:19, "Alexei Starovoitov" <alexei.starovoitov@gmail.com> wrote:
>
> On Mon, May 12, 2025 at 8:59 PM Jiayuan Chen <jiayuan.chen@linux.dev> wrote:
>
> >
> > This patch exposes the btf_custom_path feature to bpftool, allowing users
> >
> > to specify a custom BTF file when loading BPF programs using prog load or
> >
> > prog loadall commands. This feature is already supported by libbpf, and
> >
> > this patch makes it accessible through the bpftool command-line interface.
> >
> > Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
> >
> > ---
> >
> > tools/bpf/bpftool/prog.c | 11 ++++++++++-
> >
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/bpf/bpftool/prog.c b/tools/bpf/bpftool/prog.c
> >
> > index f010295350be..63f84e765b34 100644
> >
> > --- a/tools/bpf/bpftool/prog.c
> >
> > +++ b/tools/bpf/bpftool/prog.c
> >
> > @@ -1681,8 +1681,17 @@ static int load_with_options(int argc, char **argv, bool first_prog_only)
> >
> > } else if (is_prefix(*argv, "autoattach")) {
> >
> > auto_attach = true;
> >
> > NEXT_ARG();
> >
> > + } else if (is_prefix(*argv, "custom_btf")) {
> >
> > + NEXT_ARG();
> >
> > +
> >
> > + if (!REQ_ARGS(1))
> >
> > + goto err_free_reuse_maps;
> >
> > +
> >
> > + open_opts.btf_custom_path = GET_ARG();
> >
>
> I don't see a use case yet.
>
> What exactly is the scenario where it's useful ?
>
This patch just exposes the btf_custom_path feature of libbpf to bpftool.
The argument 'btf_custom_path' in libbpf is used for those kernes that
don't have CONFIG_DEBUG_INFO_BTF enabled but still want to perform CO-RE
relocations. Specifically for older kernels, separate BTF files are already
provided: https://github.com/aquasecurity/btfhub-archive/.
If we want load prog using bpftool on those systems, we have to hack
btf__load_vmlinux_btf() before or write custom loader with libbpf and specify
'btf_custom_path'.
I also found a the similar topic:
https://lore.kernel.org/bpf/20220215225856.671072-1-mauricio@kinvolk.io/
Additionally, pwru supports "--kernel-btf" which serves the same purpose as
this patch.
Therefore, using an external BTF file is a common practice.
next prev parent reply other threads:[~2025-05-14 1:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 3:58 [PATCH bpf-next v1] bpftool: Add support for custom BTF path in prog load/loadall Jiayuan Chen
2025-05-13 21:19 ` Alexei Starovoitov
2025-05-14 1:51 ` Jiayuan Chen [this message]
2025-05-14 16:39 ` Andrii Nakryiko
2025-05-14 16:52 ` Quentin Monnet
2025-05-15 1:11 ` Jiayuan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4741dfb9fa4cf32cef28d9f2b7e7c2e788430800@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=qmo@kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.