All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clement LECIGNE <clement.lecigne@netasq.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] hfs_find_init() sb->ext_tree NULL pointer dereference
Date: Sat, 11 Jun 2011 12:30:31 +0200 (CEST)	[thread overview]
Message-ID: <474215859.237587.1307788231269.JavaMail.root@work1> (raw)
In-Reply-To: <20110610214036.GA23163@infradead.org>

Hi Christoph,

----- Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Jun 08, 2011 at 01:07:55PM +0200, Clement LECIGNE wrote:
> -snip-
> Well, it can't happen in practice.  The extent file always fits into
> the first blocks for a valid extents file.  And yes, you could

If this can't happen then it should be reasonable to ban this case.

> artifically construct a filesystem where this is not true, and if you
> want to be cool call it a security issue.  But in the end anyone who
> mounts untrusted disk images has much worse issues than this, so don't
> do it.

Yes I agree but think about the case we are a simple user on the machine
without root. For example few years ago at my university I was able to
gain root priv thanks to a vulnerability in XFS quite similar to this one
(exploit which does the evil mmap(), plug usb key, automounting, sbam).

Best,

-- 
Clément LECIGNE,

      reply	other threads:[~2011-06-11 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 11:07 [BUG] hfs_find_init() sb->ext_tree NULL pointer dereference Clement LECIGNE
2011-06-10 21:40 ` Christoph Hellwig
2011-06-11 10:30   ` Clement LECIGNE [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=474215859.237587.1307788231269.JavaMail.root@work1 \
    --to=clement.lecigne@netasq.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.