From: Mike Rapoport <mike@compulab.co.il>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: tiwai@suse.de, liam.girdwood@opensource.wolfsonmicro.com,
alsa-devel@alsa-project.org, Joe Sauer <jsauer@vernier.com>
Subject: Re: [PATCH] Fix inverted Bass, Treble, Mono volume and Phone volume WM9712 mixer controls.
Date: Tue, 20 Nov 2007 14:08:33 +0200 [thread overview]
Message-ID: <4742CE41.3010107@compulab.co.il> (raw)
In-Reply-To: <1195550746-6892-5-git-send-email-broonie@opensource.wolfsonmicro.com>
Mark Brown wrote:
> From: Joe Sauer <jsauer@vernier.com>
>
> Signed-off-by: Joe Sauer <jsauer@vernier.com>
> Signed-off-by: Liam Girdwood <lg@opensource.wolfsonmicro.com>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm9712.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c
> index 986b5d5..111c266 100644
> --- a/sound/soc/codecs/wm9712.c
> +++ b/sound/soc/codecs/wm9712.c
> @@ -102,7 +102,7 @@ SOC_SINGLE("Speaker Playback ZC Switch", AC97_MASTER, 7, 1, 0),
> SOC_SINGLE("Speaker Playback Invert Switch", AC97_MASTER, 6, 1, 0),
> SOC_SINGLE("Headphone Playback ZC Switch", AC97_HEADPHONE, 7, 1, 0),
> SOC_SINGLE("Mono Playback ZC Switch", AC97_MASTER_MONO, 7, 1, 0),
> -SOC_SINGLE("Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 0),
> +SOC_SINGLE("Mono Playback Volume", AC97_MASTER_MONO, 0, 31, 1),
I think there also should be "Mono Playback Switch", otherwise there's no way
you can unmute mono playback:
+ SOC_SINGLE("Mono Playback Switch", AC97_MASTER_MONO, 15, 1, 1),
> SOC_SINGLE("ALC Target Volume", AC97_CODEC_CLASS_REV, 12, 15, 0),
> SOC_SINGLE("ALC Hold Time", AC97_CODEC_CLASS_REV, 8, 15, 0),
> @@ -131,7 +131,7 @@ SOC_SINGLE("Aux Playback Headphone Volume", AC97_CD, 12, 7, 1),
> SOC_SINGLE("Aux Playback Speaker Volume", AC97_CD, 8, 7, 1),
> SOC_SINGLE("Aux Playback Phone Volume", AC97_CD, 4, 7, 1),
>
> -SOC_SINGLE("Phone Volume", AC97_PHONE, 0, 15, 0),
> +SOC_SINGLE("Phone Volume", AC97_PHONE, 0, 15, 1),
> SOC_DOUBLE("Line Capture Volume", AC97_LINE, 8, 0, 31, 1),
>
> SOC_SINGLE("Capture 20dB Boost Switch", AC97_REC_SEL, 14, 1, 0),
> @@ -145,8 +145,8 @@ SOC_ENUM("Bass Control", wm9712_enum[5]),
> SOC_SINGLE("Bass Cut-off Switch", AC97_MASTER_TONE, 12, 1, 1),
> SOC_SINGLE("Tone Cut-off Switch", AC97_MASTER_TONE, 4, 1, 1),
> SOC_SINGLE("Playback Attenuate (-6dB) Switch", AC97_MASTER_TONE, 6, 1, 0),
> -SOC_SINGLE("Bass Volume", AC97_MASTER_TONE, 8, 15, 0),
> -SOC_SINGLE("Treble Volume", AC97_MASTER_TONE, 0, 15, 0),
> +SOC_SINGLE("Bass Volume", AC97_MASTER_TONE, 8, 15, 1),
> +SOC_SINGLE("Treble Volume", AC97_MASTER_TONE, 0, 15, 1),
>
> SOC_SINGLE("Capture ADC Switch", AC97_REC_GAIN, 15, 1, 1),
> SOC_ENUM("Capture Volume Steps", wm9712_enum[6]),
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2007-11-20 12:19 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 9:25 ASoC merge Mark Brown
2007-11-20 9:25 ` [PATCH] Update MAINTAINERS for ALSA SoC Mark Brown
2007-11-20 9:25 ` [PATCH] Reinitialise DMA on every resume Mark Brown
2007-11-20 9:25 ` [PATCH] Support suspend and resume of the I2S interface on s3c24xx Mark Brown
2007-11-20 9:25 ` [PATCH] Fix inverted Bass, Treble, Mono volume and Phone volume WM9712 mixer controls Mark Brown
2007-11-20 9:25 ` [PATCH] Add device level DAPM event Mark Brown
2007-11-20 9:25 ` [PATCH] ASoC TLV support Mark Brown
2007-11-20 9:25 ` [PATCH] Add D1 power event to power down event sequence Mark Brown
2007-11-20 9:25 ` [PATCH] Ensure PCMs are suspended Mark Brown
2007-11-20 9:25 ` [PATCH] Fix power switching support for DAPM_SWITCH widgets Mark Brown
2007-11-20 9:25 ` [PATCH] Clean up tabs Mark Brown
2007-11-20 9:25 ` [PATCH] Add support for passing kcontrols with events Mark Brown
2007-11-20 9:25 ` [PATCH] Bump ASoC core version number Mark Brown
2007-11-20 9:25 ` [PATCH] Add ASoC WM9713 codec driver Mark Brown
2007-11-20 9:25 ` [PATCH] Initial WM8753 TLV support for capture mixer Mark Brown
2007-11-20 9:25 ` [PATCH] Add ASoC AK4535 codec driver Mark Brown
2007-11-20 9:25 ` [PATCH] Add ASoC TLV320 Codec driver Mark Brown
2007-11-20 9:25 ` [PATCH] Add ASoC UDA1380 codec driver Mark Brown
2007-11-20 9:25 ` [PATCH] Add pxa2xx SSP audio support Mark Brown
2007-11-20 9:25 ` [PATCH] Add Amesom ASoC machine support Mark Brown
2007-11-20 9:25 ` [PATCH] Add ASoC Magician " Mark Brown
2007-11-20 9:25 ` [PATCH] Add TLV support for UDA1380 Mark Brown
2007-11-20 9:25 ` [PATCH] Add ASoC WM8510 codec driver Mark Brown
2007-11-20 9:25 ` [PATCH] Add ASoC WM8711 " Mark Brown
2007-11-20 11:09 ` Takashi Iwai
2007-11-20 13:12 ` Mark Brown
2007-11-20 11:07 ` [PATCH] Add TLV support for UDA1380 Takashi Iwai
2007-11-20 11:03 ` [PATCH] Add ASoC Magician machine support Takashi Iwai
2007-11-20 14:20 ` Mark Brown
2007-11-20 14:34 ` pHilipp Zabel
2007-11-20 15:43 ` Mark Brown
2007-11-20 18:48 ` pHilipp Zabel
2007-11-20 11:01 ` [PATCH] Add Amesom ASoC " Takashi Iwai
2007-11-20 12:31 ` Vladimir A. Barinov
2007-11-20 12:43 ` Mark Brown
2007-11-20 10:53 ` [PATCH] Add ASoC TLV320 Codec driver Takashi Iwai
2007-11-20 12:22 ` Mark Brown
2007-11-20 21:34 ` Jean Delvare
2007-11-21 9:48 ` Takashi Iwai
2007-11-21 12:33 ` Mark Brown
2007-11-20 12:26 ` Vladimir A. Barinov
2007-11-20 10:40 ` [PATCH] Add ASoC AK4535 codec driver Takashi Iwai
2007-11-20 15:05 ` Mark Brown
2007-11-20 14:42 ` Takashi Iwai
2007-11-20 15:35 ` Mark Brown
2007-11-20 15:20 ` Takashi Iwai
2007-11-20 10:15 ` [PATCH] Initial WM8753 TLV support for capture mixer Takashi Iwai
2007-11-20 13:45 ` Mark Brown
2007-11-20 10:33 ` [PATCH] Add ASoC WM9713 codec driver Takashi Iwai
2007-11-20 12:02 ` Clemens Ladisch
2007-11-21 16:16 ` Mark Brown
2007-11-20 10:20 ` [PATCH] Bump ASoC core version number Takashi Iwai
2007-11-20 10:07 ` [PATCH] Ensure PCMs are suspended Takashi Iwai
2007-11-20 10:06 ` [PATCH] Add D1 power event to power down event sequence Takashi Iwai
2007-11-20 10:07 ` [PATCH] Fix inverted Bass, Treble, Mono volume and Phone volume WM9712 mixer controls Takashi Iwai
2007-11-20 10:52 ` Mark Brown
2007-11-20 12:08 ` Mike Rapoport [this message]
2007-11-20 17:40 ` Mark Brown
2007-11-20 10:19 ` ASoC merge Takashi Iwai
2007-11-20 10:56 ` Mark Brown
2007-11-20 14:59 ` Jon Smirl
2007-11-20 16:56 ` Mark Brown
2007-11-20 17:43 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4742CE41.3010107@compulab.co.il \
--to=mike@compulab.co.il \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jsauer@vernier.com \
--cc=liam.girdwood@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.