From: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Cleanup partial failure of activation
Date: Wed, 21 Nov 2007 11:00:03 -0500 [thread overview]
Message-ID: <47445603.1000602@ce.jp.nec.com> (raw)
Hi,
If activate_lv() fails, callers won't call deactivate_lv().
However, activate_lv() may succeeded activation partially.
For example, in this case: (with the latest 2.02.29-cvs)
# dmsetup create --notable vg-lv0_mimage_0
# lvcreate -l1 -m1 -nlv0 vg
lvcreate fails. "lv0", "lv0_mimage_0", "lv0_mimage_1" and "lv0_mlog"
are once created but removed from the VG metadata. That's ok.
However, maps of vg-lv0 and vg-lv0_mlog remain in kernel.
Attached patch deactivates a partially activated LV so that
callers of activate_lv() don't need to care about partial failure.
Thanks,
--
Jun'ichi Nomura, NEC Corporation of America
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup-partial-activation-failure.patch
Type: text/x-patch
Size: 506 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20071121/5f942175/attachment.bin>
next reply other threads:[~2007-11-21 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 16:00 Jun'ichi Nomura [this message]
2007-11-21 22:42 ` [PATCH] Cleanup partial failure of activation Alasdair G Kergon
2007-11-22 2:16 ` Jun'ichi Nomura
2007-11-22 2:42 ` Alasdair G Kergon
2007-11-27 1:51 ` Jun'ichi Nomura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47445603.1000602@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.