From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] PATCH: fix building of 3.0.0-rc3 on powerpc and
Date: Wed, 21 Nov 2007 18:53:37 +0000 [thread overview]
Message-ID: <47447EB1.7050406@hhs.nl> (raw)
In-Reply-To: <473ECD90.5090603@hhs.nl>
Jean Delvare wrote:
> On Sun, 18 Nov 2007 18:12:02 +0100, Jean Delvare wrote:
>> On Sat, 17 Nov 2007 12:16:32 +0100, Hans de Goede wrote:
>>> Hi All,
>>>
>>> I just build 3.0.0-rc3 for Fedora's devel branch and it needs the attached
>>> patch to compile on powerpc.
>>>
>>> I've not committed this to svn as I'm not sure this is the best way todo this.
>> Good catch, thanks. I'd rather address the problem in the top Makefile:
>> there's no point in including prog/dump in the list of source
>> directories if we won't build anything there. So I'd suggest something
>> like:
>>
>> ifneq (,$(findstring $(MACHINE), i386 i486 i586 i686 x86_64))
>> SRCDIRS += prog/dump
>> endif
>>
>> in the top Makefile. Then you can even remove the architecture tests
>> in prog/dump/Module.mk, as they will be redundant, and clean up that
>> file a bit.
>
> Hans, if you are OK with my proposal, can you please give it a try on
> Fedora and then commit the fix to SVN? That's the only missing piece
> before I can release lm-sensors 3.0.0.
>
This was on my todo, I'm rather busy with all kinds a stuff atm. However I've
put it on the top of my todo now, a scratch build is building on the fedora
buildsys now (I don't have any ppc machines at home), once that has completed
successfully I'll commit the patch in the form you suggested to svn, if it
fails for some reason I'll report back here.
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-11-21 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-17 11:16 [lm-sensors] PATCH: fix building of 3.0.0-rc3 on powerpc and other Hans de Goede
2007-11-18 17:12 ` [lm-sensors] PATCH: fix building of 3.0.0-rc3 on powerpc and Jean Delvare
2007-11-21 18:28 ` Jean Delvare
2007-11-21 18:53 ` Hans de Goede [this message]
2007-11-21 20:46 ` Hans de Goede
2007-11-22 20:09 ` Jean Delvare
2007-11-23 19:52 ` Hans de Goede
2007-11-24 9:31 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47447EB1.7050406@hhs.nl \
--to=j.w.r.degoede@hhs.nl \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.