From: Zach Brown <zach.brown@oracle.com>
To: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
Linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]loop cleanup in fs/namespace.c - repost
Date: Wed, 21 Nov 2007 11:06:33 -0800 [thread overview]
Message-ID: <474481B9.9000603@oracle.com> (raw)
In-Reply-To: <47447184.6040805@gmail.com>
> The patch given below replaces the goto-loop by a while-based one.
That certainly looks fine. I would also replace the 'return' with
'break', but I guess that's more of a question of personal preference.
> Besides, it removes the export for the same routine, because there are
> no users for it outside of the core VFS code.
This doesn't look fine. Did you test this?
mntput_no_expire() is called from mntput() which is an inline function
in mount.h. So lots of callers of mntput() in modules will end up
trying to call mntput_no_expire() from modules.
$ nm fs/fuse/fuse.ko | grep mntput_no_expire
U mntput_no_expire
- z
next prev parent reply other threads:[~2007-11-21 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 17:57 [PATCH]loop cleanup in fs/namespace.c - repost Dmitri Vorobiev
2007-11-21 19:06 ` Zach Brown [this message]
2007-11-21 19:54 ` Dmitri Vorobiev
2007-11-21 19:54 ` Dmitri Vorobiev
2007-11-21 20:46 ` Zach Brown
2007-11-21 22:49 ` [PATCH] [2.6.24-rc3-mm1] loop " Dmitri Vorobiev
2007-11-21 23:24 ` Andrew Morton
2007-11-21 23:24 ` Andrew Morton
2007-11-21 23:47 ` Dmitri Vorobiev
2007-11-26 10:30 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474481B9.9000603@oracle.com \
--to=zach.brown@oracle.com \
--cc=dmitri.vorobiev@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.