From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] pata_jmicron: fix disabled port handling in jmicron_pre_reset()
Date: Thu, 22 Nov 2007 14:06:29 +0900 [thread overview]
Message-ID: <47450E55.6020305@gmail.com> (raw)
In-Reply-To: <20071119090611.GE30919@htj.mynetwork.cxm>
Tejun Heo wrote:
> There are two bugs in disabled port handling.
>
> * test in PORT_PATA0 is reversed
> * ->prereset should return -ENOENT for disabled ports not 0
>
> The first bug makes the PATA channel considered disabled but the
> second bug saves the day by returning 0. The net result is that cable
> is always left at ATA_CBL_UNKNOWN. This results in false 80c
> configuration and thus transfer errors.
>
> This patch fixes both bugs.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
Jeff, this wasn't pushed to Linus. Can you please put this into
#upstream-fixes?
Thanks.
--
tejun
next prev parent reply other threads:[~2007-11-22 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 9:06 [PATCH] pata_jmicron: fix disabled port handling in jmicron_pre_reset() Tejun Heo
2007-11-22 5:06 ` Tejun Heo [this message]
2007-11-24 0:24 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47450E55.6020305@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.