All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Steffen Prohaska <prohaska@zib.de>,
	git@vger.kernel.org, Dmitry Kakurin <Dmitry.Kakurin@gmail.com>
Subject: Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()
Date: Thu, 22 Nov 2007 08:29:29 +0100	[thread overview]
Message-ID: <47452FD9.9000501@viscovery.net> (raw)
In-Reply-To: <7v63zv9fel.fsf@gitster.siamese.dyndns.org>

Junio C Hamano schrieb:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>> Hi,
>>
>> On Wed, 21 Nov 2007, Steffen Prohaska wrote:
>>
>>> We have a function set_git_dir().  So let's use it, instead of setting 
>>> the evironment directly.
>> Does this not have a fundamental issue?  When you call other git programs 
>> with run_command(), you _need_ GIT_DIR to be set, no?
> 
> It is much worse.  set_git_dir() does not just setenv() but does
> setup_git_env() as well.

I don't see what's wrong with that. Could you please explain?

-- Hannes

      parent reply	other threads:[~2007-11-22  7:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21 20:27 [PATCH 0/3] msysgit fallout Steffen Prohaska
2007-11-21 20:27 ` [PATCH 1/3] sha1_file.c: Fix size_t related printf format warnings Steffen Prohaska
2007-11-21 20:27   ` [PATCH 2/3] builtin-init-db: use get_git_dir() instead of getenv() Steffen Prohaska
2007-11-21 20:27     ` [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir() Steffen Prohaska
2007-11-22  1:22       ` Johannes Schindelin
2007-11-22  2:34         ` Junio C Hamano
2007-11-22  6:13           ` Steffen Prohaska
2007-11-22  7:52             ` Junio C Hamano
2007-11-22  8:31               ` Steffen Prohaska
2007-11-22  9:58                 ` Johannes Sixt
2007-11-22 17:56                   ` Steffen Prohaska
2007-11-22 22:09                     ` Johannes Schindelin
2008-01-01 18:52                     ` Steffen Prohaska
2008-01-03  4:07                       ` Dmitry Kakurin
2008-01-03  6:02                         ` Steffen Prohaska
2008-01-03  6:26                           ` Dmitry Kakurin
2008-01-03  7:53                             ` Steffen Prohaska
2007-11-22  7:29           ` Johannes Sixt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47452FD9.9000501@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=Dmitry.Kakurin@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=prohaska@zib.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.