From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Peiffer Subject: Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace Date: Fri, 23 Nov 2007 09:58:24 +0100 Message-ID: <47469630.3060807@bull.net> References: <20071122155448.3193c856.pierre.peiffer@bull.net> <474680B5.7020104@fr.ibm.com> <47468347.5090303@openvz.org> <47468927.3040304@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <47468927.3040304@openvz.org> Sender: linux-kernel-owner@vger.kernel.org To: Pavel Emelyanov Cc: Cedric Le Goater , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, containers@lists.osdl.org List-Id: containers.vger.kernel.org Hi, Thanks for reviewing this ! Pavel Emelyanov wrote: > Pavel Emelyanov wrote: >> Cedric Le Goater wrote: >>> Pierre Peiffer wrote: > > [snip] > >>> Pavel, what do you think of it ? >> Looks sane, good catch, Pierre. >> >> But I'd find out whether these three ipc_ids intersect any >> cache-line. In other words I'd mark the struct ipc_ids as >> ____cacheline_aligned and checked for any differences. > > BTW! It might be also useful to keep ipc_ids closer to their > sysctl parameters. > It makes sense indeed. That would mean to have something like this, right ? struct ipc_namespace { struct kref kref; struct ipc_ids sem_ids; int sem_ctls[4]; int used_sems; struct ipc_ids msg_ids; int msg_ctlmax; int msg_ctlmnb; int msg_ctlmni; atomic_t msg_bytes; atomic_t msg_hdrs; struct ipc_ids shm_ids; size_t shm_ctlmax; size_t shm_ctlall; int shm_ctlmni; int shm_tot; }; After a quick look, that implies to rework a little bit procfs... othwise, it's not a big deal as I can see. P. >>> Acked-by: Cedric Le Goater >>> >>> Thanks, >> Thanks, >> Pavel >> >>> C. > > [snip] > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Pierre Peiffer