All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@nokia.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: Eduardo Valentin <eduardo.valentin@indt.org.br>,
	linux-omap@vger.kernel.org,
	linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH 1/2] ARM: OMAP2: Camera: Update camera driver for correct use of API's
Date: Fri, 23 Nov 2007 13:09:08 +0200	[thread overview]
Message-ID: <4746B4D4.1050605@nokia.com> (raw)
In-Reply-To: <1195663431-20390-2-git-send-email-edubezval@gmail.com>

Eduardo Valentin wrote:
> From: Eduardo Valentin <eduardo.valentin@indt.org.br>
> 
> V4l2:
> - Updates this camera driver to use correctly the new videobuf API.
> Currently, changed to use videobuf_gen and videobuf_dma_sg.
> - Removed VIDEO_BUF reference from Kconfig.
> 
> S/G:
> - Update this code to sg_* helper functions.
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@indt.org.br>

Thanks for the patch, Eduardo!

I was actually preparing a fix but perhaps a bit late. I was waiting for 
the MUSB patch to make testing it a bit easier. ;)

There's one a bit subtle change in new videobuf code (?): 
videobuf_mmap_setup now returns the number of buffers instead of zero 
when it succeeds. (I ran into this...)

Cheers,

-- 
Sakari Ailus
sakari.ailus@nokia.com

  parent reply	other threads:[~2007-11-23 11:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-21 16:43 [PATH 0/2] ARM: OMAP2: Camera: Fixes compile errors and adds little improvements Eduardo Valentin
2007-11-21 16:43 ` [PATCH 1/2] ARM: OMAP2: Camera: Update camera driver for correct use of API's Eduardo Valentin
2007-11-21 16:43   ` [PATCH 2/2] ARM: OMAP2: Camera: Improve ov9640 code on board-h4.c Eduardo Valentin
2007-11-22  9:10     ` Trilok Soni
2007-11-23 11:09   ` Sakari Ailus [this message]
2007-11-23 11:16     ` [PATCH] OMAP2: Camera: Adapt to use new videobuf and scatterlist code Sakari Ailus
2007-11-23 21:39       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4746B4D4.1050605@nokia.com \
    --to=sakari.ailus@nokia.com \
    --cc=eduardo.valentin@indt.org.br \
    --cc=edubezval@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.