From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH #upstream-fixes] sata_sil24: fix sg table sizing
Date: Fri, 23 Nov 2007 19:24:37 -0500 [thread overview]
Message-ID: <47476F45.9090004@garzik.org> (raw)
In-Reply-To: <20071122094657.GF30919@htj.mynetwork.cxm>
Tejun Heo wrote:
> sil24 unnecessarily used LIBATA_MAX_PRD and ATAPI sg table was short
> by one entry which might cause very obscure problems. This patch
> updates sg table sizing such that
>
> * One full page is used for PRB + sg table. On 4k page,
> this results in 253 sg's.
>
> * Make ATAPI sg block properly sized.
>
> * Make build fail if command block size doesn't equal PAGE_SIZE.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Jeff, this one is for #upstream-fixes.
>
> drivers/ata/sata_sil24.c | 26 +++++++++++++++++++++++---
> 1 file changed, 23 insertions(+), 3 deletions(-)
applied
prev parent reply other threads:[~2007-11-24 0:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 9:46 [PATCH #upstream-fixes] sata_sil24: fix sg table sizing Tejun Heo
2007-11-24 0:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47476F45.9090004@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.