From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata-sff: tf_load
Date: Fri, 23 Nov 2007 19:43:57 -0500 [thread overview]
Message-ID: <474773CD.4000603@garzik.org> (raw)
In-Reply-To: <20071119143456.380042a1@the-village.bc.nu>
Alan Cox wrote:
> Jeff said he preferred that the SFF tf_load followed the spec and we
> documented that anyone who needed different overrode it, rather than it
> using the ->check_status methods. No driver relies on the current behaviour.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/ata/libata-sff.c linux-2.6.24-rc2-mm1/drivers/ata/libata-sff.c
> --- linux.vanilla-2.6.24-rc2-mm1/drivers/ata/libata-sff.c 2007-11-16 17:55:11.000000000 +0000
> +++ linux-2.6.24-rc2-mm1/drivers/ata/libata-sff.c 2007-11-16 18:11:51.000000000 +0000
> @@ -147,7 +147,9 @@
> * @tf: ATA taskfile register set for storing input
> *
> * Reads ATA taskfile registers for currently-selected device
> - * into @tf.
> + * into @tf. Assumes the device has a fully SFF compliant task file
> + * layout and behaviour. If you device does not (eg has a different
> + * status method) then you will need to provide a replacement tf_read
> *
> * LOCKING:
> * Inherited from caller.
> @@ -156,7 +158,7 @@
> {
> struct ata_ioports *ioaddr = &ap->ioaddr;
>
> - tf->command = ata_chk_status(ap);
> + tf->command = ata_check_status(ap);
applied #upstream, thanks
prev parent reply other threads:[~2007-11-24 0:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 14:34 [PATCH] libata-sff: tf_load Alan Cox
2007-11-24 0:43 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474773CD.4000603@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.