Re: [PATCH 06/12] libata: separate out ata_acpi_gtm_xfermask() from pacpi_discover_modes()

[Jeff Garzik <jeff@garzik.org>]

Tejun Heo wrote:
> Finding out matching transfer mode from ACPI GTM values is useful for
> other purposes too.  Separate out the function and timing tables from
> pata_acpi::pacpi_discover_modes().
> 
> Other than checking shared-configuration bit after doing
> ata_acpi_gtm() in pacpi_discover_modes() which should be safe, this
> patch doesn't introduce any behavior change.
> 
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> ---
>  drivers/ata/libata-acpi.c |   78 +++++++++++++++++++++++++++++++++++++++++++++
>  drivers/ata/pata_acpi.c   |   66 ++++++-------------------------------
>  include/linux/libata.h    |   25 ++++++++++++++
>  3 files changed, 114 insertions(+), 55 deletions(-)
> 
> diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
> index 08a52dd..5ffa542 100644
> --- a/drivers/ata/libata-acpi.c
> +++ b/drivers/ata/libata-acpi.c
> @@ -424,6 +424,84 @@ int ata_acpi_cbl_80wire(struct ata_port *ap)
>  
>  EXPORT_SYMBOL_GPL(ata_acpi_cbl_80wire);
>  
> +/* Welcome to ACPI, bring a bucket */
> +const unsigned int ata_acpi_pio_cycle[7] = {
> +	600, 383, 240, 180, 120, 100, 80
> +};
> +EXPORT_SYMBOL_GPL(ata_acpi_pio_cycle);
> +
> +const unsigned int ata_acpi_mwdma_cycle[5] = {
> +	480, 150, 120, 100, 80
> +};
> +EXPORT_SYMBOL_GPL(ata_acpi_mwdma_cycle);
> +
> +const unsigned int ata_acpi_udma_cycle[7] = {
> +	120, 80, 60, 45, 30, 20, 15
> +};
> +EXPORT_SYMBOL_GPL(ata_acpi_udma_cycle);

these exports seem a bit ugly

If pressed I will apply, but...