From: Jeff Garzik <jeff@garzik.org>
To: ram.vepa@neterion.com
Cc: netdev@vger.kernel.org, support@neterion.com
Subject: Re: [PATCH 2.6.24 1/2]S2io: Strip the vlan tag if the vlan group is not NULL
Date: Fri, 23 Nov 2007 22:04:28 -0500 [thread overview]
Message-ID: <474794BC.5030709@garzik.org> (raw)
In-Reply-To: <1195509636.1995.39.camel@flash>
Ramkrishna Vepa wrote:
> - Updated the vlan tag stripping code as per Dave Johnson's patch
> <djohnson@sw.starentnetworks.com>
> Below is the driver behaviour for vlan_tag_strip loadable paramter,
> vlan_tag_strip - 0: Don't strip the vlan tag
> vlan_tag_strip - 1: Always strip the vlan tag
> vlan_tag_strip - 2 (default): strip the vlan tag if the
> vlan group is not NULL.
>
> Signed-off-by: Santoshkumar Rastapur <santosh.rastapur@neterion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
> ---
> diff -Nurp 2.0.26.6/drivers/net/s2io.c 2.0.26.8P1/drivers/net/s2io.c
> --- 2.0.26.6/drivers/net/s2io.c 2007-11-15 18:19:42.000000000 -0800
> +++ 2.0.26.8P1/drivers/net/s2io.c 2007-11-15 18:15:00.000000000 -0800
> @@ -46,10 +46,10 @@
> * Possible values '1' for enable and '0' for disable. Default is '1'
> * ufo: This parameter used to enable/disable UDP Fragmentation Offload(UFO)
> * Possible values '1' for enable and '0' for disable. Default is '0'
> - * vlan_tag_strip: This can be used to enable or disable vlan stripping.
> - * Possible values '1' for enable , '0' for disable.
> - * Default is '2' - which means disable in promisc mode
> - * and enable in non-promiscuous mode.
> + * vlan_tag_strip: This can be used to enable or disable vlan tag stripping.
> + * Possible values '2' for driver default, '1' for enable and
> + * '0' for disable
> + * Default is '2' - VLAN tag stripping enabled if vlan group present
> ************************************************************************/
this should be controlled via ethtool and behave like other net drivers
next prev parent reply other threads:[~2007-11-24 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 22:00 [PATCH 2.6.24 1/2]S2io: Strip the vlan tag if the vlan group is not NULL Ramkrishna Vepa
2007-11-24 3:04 ` Jeff Garzik [this message]
2007-11-24 18:11 ` Ramkrishna Vepa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474794BC.5030709@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=ram.vepa@neterion.com \
--cc=support@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.