From: Jeff Garzik <jeff@garzik.org>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: netdev@vger.kernel.org, super.firetwister@googlemail.com
Subject: Re: [PATCH] smc911x: Fix undefined CONFIG_ symbol warning
Date: Fri, 23 Nov 2007 22:09:46 -0500 [thread overview]
Message-ID: <474795FA.5050701@garzik.org> (raw)
In-Reply-To: <E1IuqlV-0002f6-IO@nanv.dk>
Peter Korsgaard wrote:
> elif defined(CONFIG_*) should be used instead of elif CONFIG_*
> so GCC doesn't give warnings about undefined symbols when the config
> option is disabled.
> ---
> drivers/net/smc911x.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h
> index 16a0edc..d04e4fa 100644
> --- a/drivers/net/smc911x.h
> +++ b/drivers/net/smc911x.h
> @@ -37,7 +37,7 @@
> #define SMC_USE_16BIT 0
> #define SMC_USE_32BIT 1
> #define SMC_IRQ_SENSE IRQF_TRIGGER_FALLING
> -#elif CONFIG_SH_MAGIC_PANEL_R2
> +#elif defined(CONFIG_SH_MAGIC_PANEL_R2)
> #define SMC_USE_SH_DMA 0
> #define SMC_USE_16BIT 0
applied all three to #upstream-fixes
next prev parent reply other threads:[~2007-11-24 3:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 14:28 [PATCH] smc911x: Fix undefined CONFIG_ symbol warning Peter Korsgaard
2007-11-24 3:09 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-21 14:28 Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474795FA.5050701@garzik.org \
--to=jeff@garzik.org \
--cc=jacmet@sunsite.dk \
--cc=netdev@vger.kernel.org \
--cc=super.firetwister@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.