Re: [patch 2/4] Timerfd v2 - new timerfd API

[Michael Kerrisk <mtk.manpages@googlemail.com>]

Hi Davide,

[...]

> +asmlinkage long sys_timerfd_create(int clockid, int flags)
>  {
> -	int error;
> +	int error, ufd;
>  	struct timerfd_ctx *ctx;
>  	struct file *file;
>  	struct inode *inode;
> -	struct itimerspec ktmr;
> -
> -	if (copy_from_user(&ktmr, utmr, sizeof(ktmr)))
> -		return -EFAULT;
>  
>  	if (clockid != CLOCK_MONOTONIC &&
>  	    clockid != CLOCK_REALTIME)
>  		return -EINVAL;

Could I suggest here, the following placeholder addition:

	if (flags != 0)
		return -EINVAL;

Later than can replaced with something like:

	if (flags & ~(O_NONBLOCK | O_CLOEXEC))
		return -EINVAL;

Having the first of the checks above will allow userland to determine what
is implemented, rather than having non-zero flags silently ignored.

Cheers,

Michael

> +	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> +	if (!ctx)
> +		return -ENOMEM;
> +
> +	init_waitqueue_head(&ctx->wqh);
> +	ctx->clockid = clockid;
> +	hrtimer_init(&ctx->tmr, clockid, HRTIMER_MODE_ABS);
> +
> +	error = anon_inode_getfd(&ufd, &inode, &file, "[timerfd]",
> +				 &timerfd_fops, ctx);
> +	if (error) {
> +		kfree(ctx);
> +		return error;
> +	}
> +
> +	return ufd;
> +}