From: "Inaky Perez-Gonzalez" <inaky@linux.intel.com>
To: "Joe Korty" <joe.korty@ccur.com>
Cc: "Andrew Morton" <akpm@osdl.org>,
"Reinette Chatre" <reinette.chatre@linux.intel.com>,
linux-kernel@vger.kernel.org,
"Inaky Perez-Gonzalez" <inaky@linux.intel.com>,
"Paul Jackson" <pj@sgi.com>
Subject: Re: [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer
Date: Wed, 4 Oct 2006 10:57:15 -0700 (PDT) [thread overview]
Message-ID: <4748.10.24.192.177.1159984635.squirrel@linux.intel.com> (raw)
In-Reply-To: <20061004171436.GA25461@tsunami.ccur.com>
Joe Korty wrote:
> On Wed, Oct 04, 2006 at 09:40:29AM -0700, Andrew Morton wrote:
>> I think we can do a version which omits the kmalloc altogether:
>
>> if (__get_user(c, ubuf++))
>> return -EFAULT;
>>
>> (Note the s/get_user/__get_user/)
>
> Nice. This eliminates the bulk of the get_user() overhead. And
> it can be merged into Inaky's enum solution too, for something
> that is both simple and efficient.
Then bitmap_parse_user() will need a quick access_ok() check
before calling down on __bitmap_parse(). Nice.
--
Inaky
prev parent reply other threads:[~2006-10-04 17:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 15:16 [PATCH] bitmap: bitmap_parse takes a kernel buffer instead of a user buffer Reinette Chatre
2006-10-03 15:20 ` inaky
2006-10-03 23:39 ` Andrew Morton
2006-10-04 2:03 ` Paul Jackson
2006-10-04 14:14 ` Joe Korty
2006-10-04 14:27 ` Paul Jackson
2006-10-04 14:55 ` Joe Korty
2006-10-04 15:06 ` Paul Jackson
2006-10-04 15:52 ` inaky
2006-10-04 16:40 ` Andrew Morton
2006-10-04 17:14 ` Joe Korty
2006-10-04 17:57 ` Inaky Perez-Gonzalez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4748.10.24.192.177.1159984635.squirrel@linux.intel.com \
--to=inaky@linux.intel.com \
--cc=akpm@osdl.org \
--cc=joe.korty@ccur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=reinette.chatre@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.