From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 084167B; Tue, 25 Oct 2022 15:15:40 +0000 (UTC) Received: by mail-wr1-f47.google.com with SMTP id a14so18851113wru.5; Tue, 25 Oct 2022 08:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r6+tPR/kzu6yF7DNjbTLOGctUOsV7x2e9sXfAZuE0k4=; b=K/0n8sGD13R9NapDToBhBYXraQ2lv2zWdofXSCF4F7BjIa6/wKU3fG1eRxjlEYsiXD c0YVX3StPEiX4/sDk8pF3BaoYxnxE5Vg9oaC/nl/oBwgbsZ9G/MHJVhgjkli8c9Lhp4n 6x0BxFVlSjNYR76+vjd8I13nj/0cnPKK2k/kheJm9JmQhW0XsHpUsVv59PlUHo9WeZtt 1puXpbkugYO9+ew8skdfhTD830InDexc/trs5T3qjef/5mdty2ideJ22l4a3lJwPTSqy HXSPlN7zpHx8QjtdKG8rXkzIhq3paMF8+XYbZQzMg3Jpv1D0phBioMJx6tAE3oMEfCRV BI5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r6+tPR/kzu6yF7DNjbTLOGctUOsV7x2e9sXfAZuE0k4=; b=tnzENKk4FzCH4gtmNsFQkVEIBZr+OX3Y/HQta+GK1kvNYlFnOSAi6IUEPi8U0saRdI eIAV2yHFGqRGIx05KpVs/VWNNDnqGUwbYngKiuDlLob6ukUvi9EhcuLBFGB4zyqSA081 IdmOYEgWYRAhNK0crzlVEaGKoIhGXuodEXFywLvPLFdB/3ycxv5Dqmaxhqn8HeF6Va5c 62OE2ymTVwHE1K2T/XfiMekTycYlfmg8YIPR5AkgqQ8tUUtDdT1AX/W3FZn9bMi8wXy/ +roBX0pwoiK7bSu50V6b1wAsoyrqsw2VHAw5aw/7K2kDPuL4iBhYtnMfqbO8FamUW6Px cj6Q== X-Gm-Message-State: ACrzQf1rvzUhqp2c8frJPN0mnN5JTdmLIuQKZ4PlSriZbtMitm3WNisp vakUnDv4wf7GqnYhNrHBPFl5yYjmAVRofQ== X-Google-Smtp-Source: AMsMyM6L8Y9mJA8bh1cRNm85m47Dxo8RyLw6mQrzRo0S0OGLSTb5Y6EY/LQsZhz+jpc7NS+0GIN/Ww== X-Received: by 2002:a05:6000:1862:b0:230:fc9a:813b with SMTP id d2-20020a056000186200b00230fc9a813bmr25408691wri.552.1666710928334; Tue, 25 Oct 2022 08:15:28 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id j37-20020a05600c1c2500b003b4c979e6bcsm12181227wms.10.2022.10.25.08.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 08:15:27 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Paul Kocialkowski Cc: mripard@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/11] media: cedrus: prefer untiled capture format Date: Tue, 25 Oct 2022 17:15:26 +0200 Message-ID: <4749341.GXAFRqVoOG@jernej-laptop> In-Reply-To: References: <20221024201515.34129-1-jernej.skrabec@gmail.com> <20221024201515.34129-9-jernej.skrabec@gmail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Dne torek, 25. oktober 2022 ob 17:05:16 CEST je Paul Kocialkowski napisal(a): > Hi Jernej, > > On Mon 24 Oct 22, 22:15, Jernej Skrabec wrote: > > While all generations of display engine on Allwinner SoCs support > > untiled format, only first generation supports tiled format. Let's > > move untiled format up, so it can be picked before tiled one. If > > Cedrus variant doesn't support untiled format, tiled will still be > > picked as default format. > > Makes sense to me. Of course the order shouldn't matter to smart-enough > userspace but it doesn't hurt to serve the most generic case first. Per Documentation/userspace-api/media/v4l/dev-stateless-decoder.rst driver should select most appropriate format for current platform by default. Setting capture format is optional by aforementioned document. Best regards, Jernej > > Acked-by: Paul Kocialkowski > > Cheers, > > Paul > > > Signed-off-by: Jernej Skrabec > > --- > > > > drivers/staging/media/sunxi/cedrus/cedrus_video.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > > b/drivers/staging/media/sunxi/cedrus/cedrus_video.c index > > 3591bf9d7d9c..f9f723ea3f79 100644 > > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > > @@ -56,13 +56,13 @@ static struct cedrus_format cedrus_formats[] = { > > > > .capabilities = CEDRUS_CAPABILITY_VP8_DEC, > > > > }, > > { > > > > - .pixelformat = V4L2_PIX_FMT_NV12_32L32, > > + .pixelformat = V4L2_PIX_FMT_NV12, > > > > .directions = CEDRUS_DECODE_DST, > > > > + .capabilities = CEDRUS_CAPABILITY_UNTILED, > > > > }, > > { > > > > - .pixelformat = V4L2_PIX_FMT_NV12, > > + .pixelformat = V4L2_PIX_FMT_NV12_32L32, > > > > .directions = CEDRUS_DECODE_DST, > > > > - .capabilities = CEDRUS_CAPABILITY_UNTILED, > > > > }, > > > > }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9F7BECDFA1 for ; Tue, 25 Oct 2022 15:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lxv/DEPJ3FW22LsutG4+RSqjgbfH014H8hwD/Sg8wnA=; b=Hx/9BR86RQUDbZ gGprFbNvcrJ2++6r22/rzVqWSMxOAgEH/VAEJCDu4beOYifIadUroKnsWGGEbbcsDFExU3qpht6rc Io5iqeCub9mfkKdLz+h15aA8TO1kDlqBms2tTvBqr0TP2+BI0k6lbJr8v+4ktKczOmdM8FC1mZFqi yeJIce/OWEfYY6iwORVEk8Nx2DaHrSTAVjKB1/Fl7/Kmk9JewkKOvVKk81/GOzcs/SBGWYlMCEC1i XHgIGaST48HFeZQBRsLUNnnxPcLPmynXF+4YcQLZxum0G/MVAJpXSXaN7833Cwm0mrY/3o2b/7/3E c4P2DqGJcx6iNsnfVxGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onLea-0062AF-Br; Tue, 25 Oct 2022 15:15:44 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onLeW-00629N-NZ for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 15:15:42 +0000 Received: by mail-wr1-x42a.google.com with SMTP id bs21so5753324wrb.4 for ; Tue, 25 Oct 2022 08:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r6+tPR/kzu6yF7DNjbTLOGctUOsV7x2e9sXfAZuE0k4=; b=K/0n8sGD13R9NapDToBhBYXraQ2lv2zWdofXSCF4F7BjIa6/wKU3fG1eRxjlEYsiXD c0YVX3StPEiX4/sDk8pF3BaoYxnxE5Vg9oaC/nl/oBwgbsZ9G/MHJVhgjkli8c9Lhp4n 6x0BxFVlSjNYR76+vjd8I13nj/0cnPKK2k/kheJm9JmQhW0XsHpUsVv59PlUHo9WeZtt 1puXpbkugYO9+ew8skdfhTD830InDexc/trs5T3qjef/5mdty2ideJ22l4a3lJwPTSqy HXSPlN7zpHx8QjtdKG8rXkzIhq3paMF8+XYbZQzMg3Jpv1D0phBioMJx6tAE3oMEfCRV BI5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r6+tPR/kzu6yF7DNjbTLOGctUOsV7x2e9sXfAZuE0k4=; b=UL642EKEoRV1x0RJd/z2ykX6BP4kPiboTL4lwHamwGV+k2I6zzxctddjUgZBrRdDvr w32JPNKeQitZCv4FnIbbLjT+rCr2fcgQooxbl20PJcf2n7rhxDeT7Q1fxjQvTnTCAGYv +D1NSjxXdWonltWmCKeL2xU4vjZA5qgNamaP/4ALSjixX9nSAXwO4WpkGwaDejDikt1w knZoOXB+e49w3wFbtgKq3r/lliHNkKsxqVSlEhsjaQkLlt+lW/jrq3Ru8oi0YkP+oPRE IxMxzUzfBxPAp5PXmFfeepg6fZE/j5d9FDTNUou/hEFvGkbIb8rW1f+qmsKVownSVyXu 09AA== X-Gm-Message-State: ACrzQf1lYHsd+meio+X49+SbniStzVvnTivxyi7SDvGgbF84IBzYGQhC VMQjmYr17k6HDns30tZyrf/0uMDQpu3W2g== X-Google-Smtp-Source: AMsMyM6L8Y9mJA8bh1cRNm85m47Dxo8RyLw6mQrzRo0S0OGLSTb5Y6EY/LQsZhz+jpc7NS+0GIN/Ww== X-Received: by 2002:a05:6000:1862:b0:230:fc9a:813b with SMTP id d2-20020a056000186200b00230fc9a813bmr25408691wri.552.1666710928334; Tue, 25 Oct 2022 08:15:28 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id j37-20020a05600c1c2500b003b4c979e6bcsm12181227wms.10.2022.10.25.08.15.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 08:15:27 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Paul Kocialkowski Cc: mripard@kernel.org, mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/11] media: cedrus: prefer untiled capture format Date: Tue, 25 Oct 2022 17:15:26 +0200 Message-ID: <4749341.GXAFRqVoOG@jernej-laptop> In-Reply-To: References: <20221024201515.34129-1-jernej.skrabec@gmail.com> <20221024201515.34129-9-jernej.skrabec@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_081540_787149_8DC942E3 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne torek, 25. oktober 2022 ob 17:05:16 CEST je Paul Kocialkowski napisal(a): > Hi Jernej, > > On Mon 24 Oct 22, 22:15, Jernej Skrabec wrote: > > While all generations of display engine on Allwinner SoCs support > > untiled format, only first generation supports tiled format. Let's > > move untiled format up, so it can be picked before tiled one. If > > Cedrus variant doesn't support untiled format, tiled will still be > > picked as default format. > > Makes sense to me. Of course the order shouldn't matter to smart-enough > userspace but it doesn't hurt to serve the most generic case first. Per Documentation/userspace-api/media/v4l/dev-stateless-decoder.rst driver should select most appropriate format for current platform by default. Setting capture format is optional by aforementioned document. Best regards, Jernej > > Acked-by: Paul Kocialkowski > > Cheers, > > Paul > > > Signed-off-by: Jernej Skrabec > > --- > > > > drivers/staging/media/sunxi/cedrus/cedrus_video.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > > b/drivers/staging/media/sunxi/cedrus/cedrus_video.c index > > 3591bf9d7d9c..f9f723ea3f79 100644 > > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > > @@ -56,13 +56,13 @@ static struct cedrus_format cedrus_formats[] = { > > > > .capabilities = CEDRUS_CAPABILITY_VP8_DEC, > > > > }, > > { > > > > - .pixelformat = V4L2_PIX_FMT_NV12_32L32, > > + .pixelformat = V4L2_PIX_FMT_NV12, > > > > .directions = CEDRUS_DECODE_DST, > > > > + .capabilities = CEDRUS_CAPABILITY_UNTILED, > > > > }, > > { > > > > - .pixelformat = V4L2_PIX_FMT_NV12, > > + .pixelformat = V4L2_PIX_FMT_NV12_32L32, > > > > .directions = CEDRUS_DECODE_DST, > > > > - .capabilities = CEDRUS_CAPABILITY_UNTILED, > > > > }, > > > > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel